From: Wols Lists <antlists@youngman.org.uk>
To: "heming.zhao@suse.com" <heming.zhao@suse.com>,
linux-raid@vger.kernel.org
Cc: neilb@suse.com, jes@trained-monkey.org
Subject: Re: [PATCH v2] mdadm/Detail: show correct state for cluster-md array
Date: Sun, 26 Jul 2020 09:14:08 +0100 [thread overview]
Message-ID: <5F1D3B50.8080006@youngman.org.uk> (raw)
In-Reply-To: <7697b7eb-76f9-8102-a490-1684e5f18acf@suse.com>
On 22/07/20 08:20, heming.zhao@suse.com wrote:
> During I was creating patch, I found the ExamineBitmap() has memory leak issue.
> I am not sure whether the leak issue should be fixed.
> (Because when mdadm cmd finish, all leaked memory will be released).
> The IsBitmapDirty() used some of ExamineBitmap() code, and I only fixed leaked issue in IsBitmapDirty().
>
My gut feel?
Firstly, "do things right" - it should be fixed.
Second - are you sure this code is not run while mdadm is running as a
daemon? It's all very well saying it will be released, but but mdadm
could be running for a looonnngg time.
Cheers,
Wol
next prev parent reply other threads:[~2020-07-26 8:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 7:11 [PATCH v2] mdadm/Detail: show correct state for cluster-md array Zhao Heming
2020-07-22 7:20 ` heming.zhao
2020-07-26 8:14 ` Wols Lists [this message]
2020-07-26 9:22 ` heming.zhao
2020-07-26 14:21 ` Wols Lists
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5F1D3B50.8080006@youngman.org.uk \
--to=antlists@youngman.org.uk \
--cc=heming.zhao@suse.com \
--cc=jes@trained-monkey.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).