Linux RAID subsystem development
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: hch@infradead.org, axboe@kernel.dk, xni@redhat.com,
	agk@redhat.com, snitzer@kernel.org, mpatocka@redhat.com,
	song@kernel.org, yukuai3@huawei.com, cl@linux.com,
	nadav.amit@gmail.com, ubizjak@gmail.com,
	akpm@linux-foundation.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev,
	linux-raid@vger.kernel.org, yi.zhang@huawei.com,
	yangerkun@huawei.com, johnny.chenyi@huawei.com
Subject: Re: [PATCH v2 0/9] md: fix is_mddev_idle()
Date: Sun, 27 Apr 2025 11:59:41 +0200	[thread overview]
Message-ID: <5b26202c-475f-48be-b6d4-b32b62eff7b1@molgen.mpg.de> (raw)
In-Reply-To: <20250427082928.131295-1-yukuai1@huaweicloud.com>

Dear Kuai,


Thank you for your patch series. Some minor comments below.


Am 27.04.25 um 10:29 schrieb Yu Kuai:
> From: Yu Kuai <yukuai3@huawei.com>

If a full cover letter is not warranted, maybe state, what patch to look 
at? (In this case 8/9.)

> Changes in v2:
>   - add patch 1-5
>   - add reviewed-by in patch 6,7,9
>   - rename mddev->last_events to mddev->normal_IO_events in patch 8
> 
> Yu Kuai (9):
>    blk-mq: remove blk_mq_in_flight()
>    block: reuse part_in_flight_rw for part_in_flight
>    block: WARN if bdev inflight counter is negative
>    block: cleanup blk_mq_in_flight_rw()

cleanup → clean up

>    block: export API to get the number of bdev inflight IO
>    md: record dm-raid gendisk in mddev
>    md: add a new api sync_io_depth

add a new → add new

>    md: fix is_mddev_idle()
>    md: cleanup accounting for issued sync IO

cleanup → clean up

>   block/blk-core.c          |   2 +-
>   block/blk-mq.c            |  22 ++---
>   block/blk-mq.h            |   5 +-
>   block/blk.h               |   1 -
>   block/genhd.c             |  69 ++++++++------
>   drivers/md/dm-raid.c      |   3 +
>   drivers/md/md.c           | 193 +++++++++++++++++++++++++++-----------
>   drivers/md/md.h           |  18 +---
>   drivers/md/raid1.c        |   3 -
>   drivers/md/raid10.c       |   9 --
>   drivers/md/raid5.c        |   8 --
>   include/linux/blkdev.h    |   1 -
>   include/linux/part_stat.h |   2 +
>   13 files changed, 194 insertions(+), 142 deletions(-)



Kind regards,

Paul

      parent reply	other threads:[~2025-04-27 10:00 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-27  8:29 [PATCH v2 0/9] md: fix is_mddev_idle() Yu Kuai
2025-04-27  8:29 ` [PATCH v2 1/9] blk-mq: remove blk_mq_in_flight() Yu Kuai
2025-04-28 13:06   ` Christoph Hellwig
2025-04-28 13:45   ` John Garry
2025-04-29  1:40     ` Yu Kuai
2025-04-29  6:25   ` Hannes Reinecke
2025-04-27  8:29 ` [PATCH v2 2/9] block: reuse part_in_flight_rw for part_in_flight Yu Kuai
2025-04-28 13:06   ` Christoph Hellwig
2025-04-28 13:47   ` John Garry
2025-04-29  6:25   ` Hannes Reinecke
2025-04-27  8:29 ` [PATCH v2 3/9] block: WARN if bdev inflight counter is negative Yu Kuai
2025-04-28 13:07   ` Christoph Hellwig
2025-04-28 14:06   ` John Garry
2025-04-29  1:43     ` Yu Kuai
2025-04-29  8:53       ` John Garry
2025-04-29  6:27   ` Hannes Reinecke
2025-04-27  8:29 ` [PATCH v2 4/9] block: cleanup blk_mq_in_flight_rw() Yu Kuai
2025-04-28 13:08   ` Christoph Hellwig
2025-04-29  6:31   ` Hannes Reinecke
2025-04-29  9:07     ` Yu Kuai
2025-04-27  8:29 ` [PATCH v2 5/9] block: export API to get the number of bdev inflight IO Yu Kuai
2025-04-28 13:08   ` Christoph Hellwig
2025-04-29  6:32   ` Hannes Reinecke
2025-04-27  8:29 ` [PATCH v2 6/9] md: record dm-raid gendisk in mddev Yu Kuai
2025-04-27  8:29 ` [PATCH v2 7/9] md: add a new api sync_io_depth Yu Kuai
2025-04-27  8:29 ` [PATCH v2 8/9] md: fix is_mddev_idle() Yu Kuai
2025-04-27  9:51   ` Paul Menzel
2025-04-29  5:45     ` Xiao Ni
2025-04-29  9:12       ` Yu Kuai
2025-04-27  8:29 ` [PATCH v2 9/9] md: cleanup accounting for issued sync IO Yu Kuai
2025-04-27  9:59 ` Paul Menzel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b26202c-475f-48be-b6d4-b32b62eff7b1@molgen.mpg.de \
    --to=pmenzel@molgen.mpg.de \
    --cc=agk@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=cl@linux.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=hch@infradead.org \
    --cc=johnny.chenyi@huawei.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=nadav.amit@gmail.com \
    --cc=snitzer@kernel.org \
    --cc=song@kernel.org \
    --cc=ubizjak@gmail.com \
    --cc=xni@redhat.com \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai1@huaweicloud.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox