Re: [PATCH 00/34] address various checkpatch.pl requirements

[Guoqing Jiang <guoqing.jiang@linux.dev>]

On 3/7/23 05:27, heinzm@redhat.com wrote:
> From: heinzm <heinzm@redhat.com>
>
> This patch series addresses checkpatch.pl reuirements.
>
> It is grouped into patches addressing errors first then warnings.
> Each patch fixes flaws in one semantical respect (e.g. fix spaces).
>
> Series passed upstream regression tests succesfully.
>
> Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
> Reviewed-by: Nigel Croxon <ncroxon@redhat.com>
> Reviewed-by: Xiao Ni <xni@redhat.com>
> Tested-by: Nigel Croxon <ncroxon@redhat.com>
> Tested-by: Xiao Ni <xni@redhat.com>
>
> Heinz Mauelshagen (34):
>    md: fix required/prohibited spaces [ERROR]
>    md: fix 'foo*' and 'foo * bar' [ERROR]
>    md: fix EXPORT_SYMBOL() to follow its functions immediately [ERROR]
>    md: adjust braces on functions/structures [ERROR]
>    md: correct code indent [ERROR]
>    md: move trailing statements to next line [ERROR]
>    md: consistent spacing around operators [ERROR]
>    md: don't initialize statics/globals to 0/false [ERROR]
>    md: else should follow close curly brace [ERROR]
>    md: remove trailing whitespace [ERROR]
>    md: do not use assignment in if condition [ERROR]
>    md: add missing blank line after declaration [WARNING]
>    md: space prohibited between function and opening parenthesis [WARNING]
>    md: prefer seq_put[cs]() to seq_printf() |WARNING]
>    md: avoid multiple line dereference [WARNING}
>    md: fix block comments [WARNING]
>    md: add missing function identifier names to function definition arguments [WARNING]
>    md: avoid redundant braces in single line statements [WARNING]
>    md: place constant on the right side of a test [WARNING]
>    md: avoid pointless filenames in files [WARNING]
>    md: avoid useless else after break or return [WARNING]
>    md: don't indent labels [WARNING]
>    md: fix code indent for conditional statements [WARNING]
>    md: prefer octal permissions [WARNING]
>    md: remove bogus IS_ENABLED() macro [WARNING]
>    md autodetect: correct placement of __initdata [WARNING]
>    md: prefer using "%s...", __func__ [WARNING]
>    md pq: adjust __attribute__ [WARNING]
>    md: prefer 'unsigned int' [WARNING]
>    md: prefer kmap_local_page() instead of deprecated kmap_atomic() [WARNING]
>    md raid5: prefer 'int' instead of 'signed' [WARNING]
>    md: prefer kvmalloc_array() with multiply [WARNING]
>    md: avoid splitting quoted strings [WARNING]
>    md: avoid return in void functions [WARNING]

Most of them do have empty log ...

And I don't think it makes sense to run checkpatch on old code.

Thanks,
Guoqing