From: "Tkaczyk, Mariusz" <mariusz.tkaczyk@linux.intel.com>
To: Nigel Croxon <ncroxon@redhat.com>,
neilb@suse.de, jes@trained-monkey.org, xni@redhat.com,
linux-raid@vger.kernel.org
Subject: Re: [PATCH V2] Fix buffer size warning for strcpy
Date: Mon, 23 Aug 2021 08:55:08 +0200 [thread overview]
Message-ID: <5d28eff3-d693-92c5-6e84-54846b36a480@linux.intel.com> (raw)
In-Reply-To: <20210819131017.2511208-1-ncroxon@redhat.com>
On 19.08.2021 15:10, Nigel Croxon wrote:
> + memset(ve->name, '\0', sizeof(ve->name));
> + if (name) {
> + int l = strlen(ve->name);
> + if (l > 16)
> + l = 16;
> + memcpy(ve->name, name, l);
> + }
What about:
if (name)
/*
* Name might not be null terminated.
*/
strncpy(ve->name, name, sizeof(ve->name));
else
memset(ve->name, '\0', sizeof(ve->name));
If size is less than sizeof(ve->name) then strncpy will automatically
fill rest with "\0".
Mariusz
next prev parent reply other threads:[~2021-08-23 6:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 13:10 [PATCH V2] Fix buffer size warning for strcpy Nigel Croxon
2021-08-19 22:16 ` NeilBrown
2021-08-22 14:26 ` Gal Ofri
2021-08-22 14:30 ` Gal Ofri
2021-08-22 22:05 ` NeilBrown
2021-08-23 6:55 ` Tkaczyk, Mariusz [this message]
2021-08-23 22:46 ` NeilBrown
2021-08-24 7:36 ` hillr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d28eff3-d693-92c5-6e84-54846b36a480@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=jes@trained-monkey.org \
--cc=linux-raid@vger.kernel.org \
--cc=ncroxon@redhat.com \
--cc=neilb@suse.de \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox