From: "Raz Ben-Jehuda(caro)" <raziebe@gmail.com>
To: Neil Brown <neilb@cse.unsw.edu.au>
Cc: linux-raid@vger.kernel.org
Subject: Re: raid1 faulty disk --> hot adding
Date: Fri, 10 Jun 2005 09:21:09 +0300 [thread overview]
Message-ID: <5d96567b05060923214dcefa75@mail.gmail.com> (raw)
In-Reply-To: <17064.58907.391363.673963@cse.unsw.edu.au>
Yes. my mistake.
I tried it with two ramdisks and I made some stupid mistake.
thanks Neil
6/10/05, Neil Brown <neilb@cse.unsw.edu.au> wrote:
> On Friday June 10, raziebe@gmail.com wrote:
> > Hello guys.
> > I tried to to raidhotadd a faulty disk to a mirror and it failed
> > saying that "bd_claim failed on..."
> > i took a dive into the code and it seems that when a disk in the raid
> > fails the bd_holder fileld in
> > the block_device struct remained with the old value although the disk
> > was faulty.
> > So the logical thing to do was to set rdev->bdev->bd_holder to 0x00 .
> > I did it in the error() routine in raid1.c .
> > This way I manage to hotadd a disk.
> > Are there anyone here that can point his view regarding this matter ?
>
> If a drive fails, and you want to re-add it, what you should do is
> first remove it, and then add it.
> raidhotremove /dev/mdX /dev/sdY
> raidhotadd /dev/mdX /dev/sdY
>
> (or equivalent mdadm commands).
>
> clearing bd_holder is certainly not the right thing to do.
>
> NeilBrown
>
>
--
Raz
Long Live the Penguin
prev parent reply other threads:[~2005-06-10 6:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-09 23:12 raid1 faulty disk --> hot adding Raz Ben-Jehuda(caro)
2005-06-10 1:00 ` Neil Brown
2005-06-10 6:21 ` Raz Ben-Jehuda(caro) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d96567b05060923214dcefa75@mail.gmail.com \
--to=raziebe@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).