From: antlists <antlists@youngman.org.uk>
To: Paul Menzel <pmenzel@molgen.mpg.de>, Song Liu <song@kernel.org>,
Yufen Yu <yuyufen@huawei.com>
Cc: linux-raid <linux-raid@vger.kernel.org>,
NeilBrown <neilb@suse.com>,
Guoqing Jiang <guoqing.jiang@cloud.ionos.com>,
Hou Tao <houtao1@huawei.com>
Subject: Re: [PATCH v5 01/16] md/raid456: covert macro define of STRIPE_* as members of struct r5conf
Date: Sun, 12 Jul 2020 23:55:14 +0100 [thread overview]
Message-ID: <61fe17a6-1c2c-7f95-eba7-167d8d0d30c2@youngman.org.uk> (raw)
In-Reply-To: <3bf71b7a-b457-c5e4-34df-bdea5cf2abc3@molgen.mpg.de>
On 02/07/2020 19:23, Paul Menzel wrote:
> Dear Yufen,
>
>
> Am 02.07.20 um 20:15 schrieb Song Liu:
>> On Thu, Jul 2, 2020 at 5:05 AM Yufen Yu <yuyufen@huawei.com> wrote:
>>>
>>> We covert STRIPE_SIZE, STRIPE_SHIFT and STRIPE_SECTORS to stripe_size,
>>> stripe_shift and stripe_sectors as members of struct r5conf. Then each
>>> raid456 array can config different stripe_size. This patch is prepared
>>> for following configurable stripe_size.
>>>
>>> Simply replace word STRIPE_ with conf->stripe_ and add 'conf' argument
>>> for function stripe_hash_locks_hash() and r5_next_bio() to get
>>> stripe_size.
>>> After that, we initialize stripe_size into setup_conf().
>>>
>>> Signed-off-by: Yufen Yu <yuyufen@huawei.com>
>>
>> This patch looks good. Please fix the warning found by the kernel test
>> bot.
>> Also a nitpick below.
>
> Please also fix the typo *covert* to *Convert* in the commit message
> summary, and maybe use *to* instead of *as*.
Actually, if I understand the Pidgin correctly, "as" is correct grammar.
"to" just doesn't work for me ...
>
> > Convert macro define of STRIPE_* to members of struct r5conf
>
Cheers,
Wol
next prev parent reply other threads:[~2020-07-12 22:55 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 12:06 [PATCH v5 00/16] md/raid5: set STRIPE_SIZE as a configurable value Yufen Yu
2020-07-02 12:06 ` [PATCH v5 01/16] md/raid456: covert macro define of STRIPE_* as members of struct r5conf Yufen Yu
2020-07-02 14:51 ` kernel test robot
2020-07-02 15:44 ` kernel test robot
2020-07-02 18:15 ` Song Liu
2020-07-02 18:23 ` Paul Menzel
2020-07-12 22:55 ` antlists [this message]
2020-07-06 9:09 ` Guoqing Jiang
2020-07-06 11:34 ` Guoqing Jiang
2020-07-08 2:22 ` Yufen Yu
2020-07-02 12:06 ` [PATCH v5 02/16] md/raid5: add sysfs entry to set and show stripe_size Yufen Yu
2020-07-02 22:14 ` Song Liu
2020-07-02 12:06 ` [PATCH v5 03/16] md/raid5: set default stripe_size as 4096 Yufen Yu
2020-07-02 12:06 ` [PATCH v5 04/16] md/raid5: add a member of r5pages for struct stripe_head Yufen Yu
2020-07-02 22:56 ` Song Liu
2020-07-03 1:22 ` Jason Yan
2020-07-02 12:06 ` [PATCH v5 05/16] md/raid5: allocate and free shared pages of r5pages Yufen Yu
2020-07-02 12:06 ` [PATCH v5 06/16] md/raid5: set correct page offset for bi_io_vec in ops_run_io() Yufen Yu
2020-07-02 12:06 ` [PATCH v5 07/16] md/raid5: set correct page offset for async_copy_data() Yufen Yu
2020-07-02 12:06 ` [PATCH v5 08/16] md/raid5: resize stripes and set correct offset when reshape array Yufen Yu
2020-07-02 12:06 ` [PATCH v5 09/16] md/raid5: add new xor function to support different page offset Yufen Yu
2020-07-02 12:06 ` [PATCH v5 10/16] md/raid5: add offset array in scribble buffer Yufen Yu
2020-07-02 12:06 ` [PATCH v5 11/16] md/raid5: compute xor with correct page offset Yufen Yu
2020-07-02 12:06 ` [PATCH v5 12/16] md/raid5: support config stripe_size by sysfs entry Yufen Yu
2020-07-02 22:38 ` Song Liu
2020-07-04 12:25 ` Yufen Yu
2020-07-02 12:06 ` [PATCH v5 13/16] md/raid6: let syndrome computor support different page offset Yufen Yu
2020-07-02 12:06 ` [PATCH v5 14/16] md/raid6: let async recovery function " Yufen Yu
2020-07-02 12:06 ` [PATCH v5 15/16] md/raid6: compute syndrome with correct " Yufen Yu
2020-07-02 12:06 ` [PATCH v5 16/16] raid6test: adaptation with syndrome function Yufen Yu
2020-07-02 23:00 ` [PATCH v5 00/16] md/raid5: set STRIPE_SIZE as a configurable value Song Liu
2020-07-08 13:14 ` Yufen Yu
2020-07-08 23:55 ` Song Liu
2020-07-09 13:27 ` Yufen Yu
2020-07-10 16:09 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61fe17a6-1c2c-7f95-eba7-167d8d0d30c2@youngman.org.uk \
--to=antlists@youngman.org.uk \
--cc=guoqing.jiang@cloud.ionos.com \
--cc=houtao1@huawei.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=pmenzel@molgen.mpg.de \
--cc=song@kernel.org \
--cc=yuyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox