From: Molle Bestefich <molle.bestefich@gmail.com>
To: NeilBrown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH md ] Better handling of readerrors with raid5.
Date: Wed, 21 Sep 2005 00:15:29 +0000 [thread overview]
Message-ID: <62b0912f050920171550edcab1@mail.gmail.com> (raw)
In-Reply-To: <1050916030157.11071@suse.de>
NeilBrown wrote:
> TESTERS WANTED!! SEE BELOW...
>
> This patch changes the behaviour of raid5 when it gets a read error.
> Instead of just failing the device, it tried to find out what should
> have been there, and writes it over the bad block.
Jip-hee! Beautiful!!
Neil, a big, warm and fuzzy Thank You for all the hard work you put into MD!
I do not have a test system, so I've tried to apply the patch to a
smallish (6 disk ata) live system instead. (Am I sane?)
Some of the disks have probably developed a couple of bad blocks here
and there by now. I imagine doing a 'dd' from the MD device will read
at least 83% of all sectors (?), so there's a fair chance I'll hit
something if it's there.
Applying the patch doesn't quite work for me:
==============================================
linux-2.6.13.2 # patch --dry-run -p0 < md-rewrite-bad-blocks.patch
patching file ./drivers/md/raid5.c
Hunk #1 succeeded at 339 (offset -10 lines).
Hunk #3 succeeded at 963 (offset -20 lines).
Hunk #4 FAILED at 983.
Hunk #5 succeeded at 1044 (offset -2 lines).
Hunk #6 succeeded at 1274 (offset -32 lines).
1 out of 6 hunks FAILED -- saving rejects to file ./drivers/md/raid5.c.rej
patching file ./include/linux/raid/raid5.h
Hunk #1 succeeded at 153 (offset -1 lines).
==============================================
Hunk #4 succeds if given a fuzz of 3...
Is it safe to use the patch with 2.6.13.2?
next prev parent reply other threads:[~2005-09-21 0:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050916125754.11044.patches@notabene>
2005-09-16 3:01 ` [PATCH md ] Better handling of readerrors with raid5 NeilBrown
2005-09-16 16:53 ` Mike Hardy
2005-09-16 21:39 ` Neil Brown
2005-09-18 22:06 ` JaniD++
2005-09-21 0:15 ` Molle Bestefich [this message]
2005-09-21 9:14 ` Neil Brown
2005-09-21 15:07 ` Al Boldi
2005-10-23 3:57 ` Patrik Jonsson
2005-10-23 22:52 ` Neil Brown
2005-10-11 14:31 ` Mattias Wadenstein
2005-12-22 22:23 ` Stephan van Hienen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62b0912f050920171550edcab1@mail.gmail.com \
--to=molle.bestefich@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).