Linux RAID subsystem development
 help / color / mirror / Atom feed
From: Roy Sigurd Karlsbakk <roy@karlsbakk.net>
To: Adam Goryachev <mailinglists@websitemanagers.com.au>
Cc: "David C. Rankin" <drankinatty@suddenlinkmail.com>,
	Linux Raid <linux-raid@vger.kernel.org>
Subject: Re: Feature request: Remove the badblocks list
Date: Wed, 2 Sep 2020 17:25:11 +0200 (CEST)	[thread overview]
Message-ID: <675330127.983718.1599060311646.JavaMail.zimbra@karlsbakk.net> (raw)
In-Reply-To: <afb20610-530e-4185-69c3-4ceef939fc6f@websitemanagers.com.au>

>> I'd better want md to stop fixing "somebody else's problem", that is, the disk,
>> and rather just do its job. As for the case, I have tried to manually read
>> those sectors named in the badblocks list and they all work. All of them. But
>> then, there's no fixing, since they are proclaimed dead. So are their siblings'
>> sectors with the same number, regardless of status.
> Just because you can read them, doesn't mean you can write them.
> Clearly, at some point in time, one of your drives failed. You now need
> to recover from that failed drive in the most sensible way.
>> If a drive has multiple issues with bad sector, kick it out. It doesn't have
>> anything to do in the RAID anymore
> 
> And if a group of 100 sectors are bad on drive 1, and 100 different
> sectors on drive 2, you want to kick both drives out, and destroy all
> your data until you can create a new array and restore from backup?
> 
> OR, just mark those parts of all disks faulty, and at some point in the
> future, you replace the disks, and then find a way to tell MD that the
> sectors are working now (and preferably, re-test them before marking
> them as OK)?
> 
> BTW, I just found this:
> 
> https://raid.wiki.kernel.org/index.php/The_Badblocks_controversy

I linked to that earlier in the thread

> Which suggests that there is indeed a bug which should be hunted and
> fixed, and that actually the BBL isn't populated via failed writes, it
> is populated by failed reads while doing a replace/add, AND the failed
> read is from the source drive AND the parity/mirror drives.

It is neither hunted down nor fixed. It's the same thing and it has stayed the same for these years.

> Either way, perhaps what is needed (if you are interested) is a
> repeatable test scenario causing the problem, which could then be used
> to identify and fix the bug.

I have tried several things and all show the same. I just don't know how to tell md "this drive's sector X is bad, so flag it so".

Again, this is not the way to walk around a problem. What this does is just hiding real problems and let them grow in generations instead of just flagging a bad drive as bad, since that's the originating problem here.

Vennlig hilsen

roy
-- 
Roy Sigurd Karlsbakk
(+47) 98013356
http://blogg.karlsbakk.net/
GPG Public key: http://karlsbakk.net/roysigurdkarlsbakk.pubkey.txt
--
Hið góða skaltu í stein höggva, hið illa í snjó rita.


  reply	other threads:[~2020-09-02 15:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18 18:00 Feature request: Remove the badblocks list Roy Sigurd Karlsbakk
2020-08-18 19:26 ` Wols Lists
2020-08-18 19:34   ` Piergiorgio Sartor
2020-08-18 19:43   ` Phil Turmel
2020-08-18 21:03 ` Håkon Struijk Holmen
2020-08-22  1:42   ` David C. Rankin
2020-09-02 13:36     ` Roy Sigurd Karlsbakk
2020-09-02 14:34       ` Adam Goryachev
2020-09-02 14:50         ` Roy Sigurd Karlsbakk
2020-09-02 15:09           ` Adam Goryachev
2020-09-02 15:25             ` Roy Sigurd Karlsbakk [this message]
2020-09-02 16:32               ` Adam Goryachev
2020-09-02 16:50                 ` Roy Sigurd Karlsbakk
2020-09-02 19:45                 ` Håkon Struijk Holmen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=675330127.983718.1599060311646.JavaMail.zimbra@karlsbakk.net \
    --to=roy@karlsbakk.net \
    --cc=drankinatty@suddenlinkmail.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=mailinglists@websitemanagers.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox