public inbox for linux-raid@vger.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <jes@trained-monkey.org>
To: Sudhakar Panneerselvam <sudhakar.panneerselvam@oracle.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 5/5] tests: avoid passing chunk size to raid1.
Date: Mon, 2 Aug 2021 11:49:36 -0400	[thread overview]
Message-ID: <698a03a1-0e87-d2c5-eaec-90cd0a29403e@trained-monkey.org> (raw)
In-Reply-To: <20210722182936.GA25474@oracle.com>

On 7/22/21 2:29 PM, Sudhakar Panneerselvam wrote:
> '04update-metadata' test fails with error, "specifying chunk size is
> forbidden for this level" added by commit, 5b30a34aa4b5e. Hence,
> correcting the test to ignore passing chunk size to raid1.
> 
> Signed-off-by: Sudhakar Panneerselvam <sudhakar.panneerselvam@oracle.com>
> ---
>  tests/04update-metadata | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/04update-metadata b/tests/04update-metadata
> index 08c14af7ed29..591009d2797e 100644
> --- a/tests/04update-metadata
> +++ b/tests/04update-metadata
> @@ -11,7 +11,12 @@ dlist="$dev0 $dev1 $dev2 $dev3"
>  for ls in linear/4 raid1/1 raid5/3 raid6/2
>  do
>    s=${ls#*/} l=${ls%/*}
> -  mdadm -CR --assume-clean -e 0.90 $md0 --level $l -n 4 -c 64 $dlist
> +  if [[ $l == 'raid1' ]]
> +  then
> +    mdadm -CR --assume-clean -e 0.90 $md0 --level $l -n 4 $dlist
> +  else
> +    mdadm -CR --assume-clean -e 0.90 $md0 --level $l -n 4 -c 64 $dlist
> +  fi
>    testdev $md0 $s 19904 64
>    mdadm -S $md0
>    mdadm -A $md0 --update=metadata $dlist
> 

I took a patch from Mateusz that fixed this in a more generic way. If
it's still a problem, please let me know.

Thanks,
Jes


      reply	other threads:[~2021-08-02 15:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22 18:29 [PATCH 5/5] tests: avoid passing chunk size to raid1 Sudhakar Panneerselvam
2021-08-02 15:49 ` Jes Sorensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=698a03a1-0e87-d2c5-eaec-90cd0a29403e@trained-monkey.org \
    --to=jes@trained-monkey.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=sudhakar.panneerselvam@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox