From: Guoqing Jiang <guoqing.jiang@linux.dev>
To: Christoph Hellwig <hch@lst.de>, Song Liu <song@kernel.org>
Cc: Logan Gunthorpe <logang@deltatee.com>,
linux-raid@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 3/9] md: rename md_free to md_kobj_release
Date: Fri, 15 Jul 2022 17:00:14 +0800 [thread overview]
Message-ID: <6ab9c6db-7fd1-ebee-b2da-7a303c8a9417@linux.dev> (raw)
In-Reply-To: <20220713113125.2232975-4-hch@lst.de>
On 7/13/22 7:31 PM, Christoph Hellwig wrote:
> The md_free name is rather misleading, so pick a better one.
>
> Signed-off-by: Christoph Hellwig<hch@lst.de>
> ---
> drivers/md/md.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 2beaadd202c4e..3127dcb8102ce 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -5590,7 +5590,7 @@ md_attr_store(struct kobject *kobj, struct attribute *attr,
> return rv;
> }
>
> -static void md_free(struct kobject *ko)
> +static void md_kobj_release(struct kobject **ko*)
While at it, how about rename it to kobj?
> {
> struct mddev *mddev = container_of(ko, struct mddev, kobj);
>
> @@ -5610,7 +5610,7 @@ static const struct sysfs_ops md_sysfs_ops = {
> .store = md_attr_store,
> };
> static struct kobj_type md_ktype = {
> - .release = md_free,
> + .release = md_kobj_release,
> .sysfs_ops = &md_sysfs_ops,
> .default_groups = md_attr_groups,
> };
Acked-by: Guoqing Jiang <guoqing.jiang@linux.dev>
Thanks,
Guoqing
next prev parent reply other threads:[~2022-07-15 9:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 11:31 fix md disk_name lifetime problems v2 Christoph Hellwig
2022-07-13 11:31 ` [PATCH 1/9] md: fix error handling in md_alloc Christoph Hellwig
2022-07-13 15:26 ` Logan Gunthorpe
2022-07-13 16:31 ` Logan Gunthorpe
2022-07-13 11:31 ` [PATCH 2/9] md: implement ->free_disk Christoph Hellwig
2022-07-13 11:31 ` [PATCH 3/9] md: rename md_free to md_kobj_release Christoph Hellwig
2022-07-15 9:00 ` Guoqing Jiang [this message]
2022-07-13 11:31 ` [PATCH 4/9] md: factor out the rdev overlaps check from rdev_size_store Christoph Hellwig
2022-07-15 9:01 ` Guoqing Jiang
2022-07-13 11:31 ` [PATCH 5/9] md: stop using for_each_mddev in md_do_sync Christoph Hellwig
2022-07-13 11:31 ` [PATCH 6/9] md: stop using for_each_mddev in md_notify_reboot Christoph Hellwig
2022-07-15 9:02 ` Guoqing Jiang
2022-07-13 11:31 ` [PATCH 7/9] md: stop using for_each_mddev in md_exit Christoph Hellwig
2022-07-13 11:31 ` [PATCH 8/9] md: only delete entries from all_mddevs when the disk is freed Christoph Hellwig
2022-07-15 9:03 ` Guoqing Jiang
2022-07-13 11:31 ` [PATCH 9/9] md: simplify md_open Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ab9c6db-7fd1-ebee-b2da-7a303c8a9417@linux.dev \
--to=guoqing.jiang@linux.dev \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).