From: Jens Axboe <axboe@kernel.dk>
To: Song Liu <songliubraving@meta.com>,
linux-raid <linux-raid@vger.kernel.org>
Cc: Li Nan <linan122@huawei.com>, Yu Kuai <yukuai1@huaweicloud.com>,
Yu Kuai <yukuai3@huawei.com>,
Florian-Ewald Mueller <florian-ewald.mueller@ionos.com>,
Song Liu <song@kernel.org>
Subject: Re: [GIT PULL] md-6.10 20240425
Date: Thu, 25 Apr 2024 14:02:28 -0600 [thread overview]
Message-ID: <6addafce-5a59-47d0-b580-9ec3e54fc805@kernel.dk> (raw)
In-Reply-To: <CE08A995-B84A-4B4B-BC7A-0EB73319877E@fb.com>
On 4/25/24 1:51 PM, Song Liu wrote:
> Hi Jens,
>
> Please consider pulling the following changes for md-6.10 on top of your
> for-6.10/block branch. These changes contain various fixes by Yu Kuai,
> Li Nan, and Florian-Ewald Mueller.
>
> Please note that change "md: Fix overflow in is_mddev_idle" changes
> gendisk->sync_io from blkdev.h. This is only used by md, so I included
> this change in this pull request.
A bit dubious to just bump the counts to 64-bit, I think. You only care
about the difference, so regular integer math should suffice. In fact
you only care about the difference. Feels like a bit of a lazy fix to be
honest.
I've pulled this, but I would strongly suggest to re-visit this change
and spend a bit more time getting this right, rather than just blindly
bumping everything to a 64-bit value. I don't care about the md bits
here, just the gendisk side.
--
Jens Axboe
next prev parent reply other threads:[~2024-04-25 20:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 19:51 [GIT PULL] md-6.10 20240425 Song Liu
2024-04-25 20:02 ` Jens Axboe [this message]
2024-04-25 20:29 ` Song Liu
2024-04-25 20:29 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6addafce-5a59-47d0-b580-9ec3e54fc805@kernel.dk \
--to=axboe@kernel.dk \
--cc=florian-ewald.mueller@ionos.com \
--cc=linan122@huawei.com \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=songliubraving@meta.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox