From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from va-2-28.ptr.blmpb.com (va-2-28.ptr.blmpb.com [209.127.231.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96B1B313E07 for ; Tue, 14 Apr 2026 06:20:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.127.231.28 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776147659; cv=none; b=inhRnx07Tbr9xnB3a5vaD+DitBl/cbSwC5jBJTxQszRaFIX202GJaRRdIh8v26iqAAaSmOkF/R/1GXGNLIriSE8EnjafxHWf312arJQ2OH4Bi4nZIMhkP+dnbRoY85gd8x4UuFJYx6qso7megEccfCmXF03lyn0U8qmeAKNa6h8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776147659; c=relaxed/simple; bh=adDnJTbmOAkkTbAC/CrZrJCFwMvvEFA+H33FAoiuRyg=; h=From:Content-Type:Cc:Message-Id:Mime-Version:References:To: Subject:Date:In-Reply-To; b=IoRutftXlZHQ+veN02Diso10NeHDKqEVYjjFhBxPABXmhgyYpJ9dQrQlD/tT9z0G8ecJg94UeOCf8UN4CWFnhhLYlBLCm+CtZtYo8h3v5iAPUJaK7hHZO8xMbL6WtrbEcPVVmYPSPWJwCBC18v9A42JzRgiahezWuK4D5CZ4t3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fnnas.com; spf=pass smtp.mailfrom=fnnas.com; dkim=pass (2048-bit key) header.d=fnnas-com.20200927.dkim.feishu.cn header.i=@fnnas-com.20200927.dkim.feishu.cn header.b=Gkwom5Eo; arc=none smtp.client-ip=209.127.231.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fnnas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fnnas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fnnas-com.20200927.dkim.feishu.cn header.i=@fnnas-com.20200927.dkim.feishu.cn header.b="Gkwom5Eo" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=s1; d=fnnas-com.20200927.dkim.feishu.cn; t=1776147646; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=adDnJTbmOAkkTbAC/CrZrJCFwMvvEFA+H33FAoiuRyg=; b=Gkwom5Eom1x7BlUpShaA5lDTdSTs5tmohfaDxi6tWbHknzNncncjrNsxZagCQgSEGlClhb u3yqzPBE2rRjjNnK21CFE6Q5mLIWt5CsOp0ugsXz0GN2UkaiR4PbYVFiRGWXuZiDyT6dzO g9a0t41BeZ5mQ8iLSC9W72I/BrU4c+bgXetaF8m3SWVeutiCq6xQf6PrMApaMc3dKnThrC OEmjwoGg5oaVglFqcW1ERcfeWdbm7YGSeSZ/emAUlXk/izMiDfGDMonnDLzdh1JnZh/W5m M9EM94OxVPo3q6xe+6JuSR8vCvhayvJsVYPXAxHaFXXcCCknYdtBOae5PJ9TGA== From: "Yu Kuai" Content-Type: text/plain; charset=UTF-8 Received: from [192.168.1.104] ([39.182.0.184]) by smtp.feishu.cn with ESMTPS; Tue, 14 Apr 2026 14:20:43 +0800 Reply-To: yukuai@fnnas.com Cc: , , "Xiao Ni" , "Nigel Croxon" Message-Id: <717caf7b-03ef-41d8-bbb3-f6ce5d4a49fa@fnnas.com> Content-Language: en-US User-Agent: Mozilla Thunderbird Precedence: bulk X-Mailing-List: linux-raid@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Original-From: Yu Kuai References: <20260413224556.1914504-1-bmarzins@redhat.com> <0e53701a-2471-9b72-eef8-27b168a0f3ea@huaweicloud.com> Content-Transfer-Encoding: quoted-printable To: "Li Nan" , "Benjamin Marzinski" , "Yu Kuai" , "Song Liu" , Subject: Re: [PATCH] md/raid5: Don't set bi_status on STRIPE_WAIT_RESHAPE Date: Tue, 14 Apr 2026 14:20:40 +0800 In-Reply-To: <0e53701a-2471-9b72-eef8-27b168a0f3ea@huaweicloud.com> X-Lms-Return-Path: Hi, =E5=9C=A8 2026/4/14 9:25, Li Nan =E5=86=99=E9=81=93: > > > =E5=9C=A8 2026/4/14 6:45, Benjamin Marzinski =E5=86=99=E9=81=93: >> When make_stripe_request() encounters a clone bio that crosses the >> reshape position while the reshape cannot make progress, it was setting >> bi->bi_status to BLK_STS_RESOURCE when returning STRIPE_WAIT_RESHAPE. >> This will update the original bio's bi_status in md_end_clone_io(). >> Afterwards, md_handle_request() will wait for the device to become >> unsuspended and submit a new cloned bio. However, even if that clone >> completes successfully, it will not clear the original bio's bi_status. >> >> There's no need to set bi_status when retrying the bio. md will already >> error out the bio correctly if it is set REQ_NOWAIT. Otherwise it will >> be retried. dm-raid will already end the bio with DM_MAPIO_REQUEUE. >> >> Signed-off-by: Benjamin Marzinski >> --- >> =C2=A0 drivers/md/raid5.c | 1 - >> =C2=A0 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c >> index dc0c680ca199..690c65cd1e29 100644 >> --- a/drivers/md/raid5.c >> +++ b/drivers/md/raid5.c >> @@ -6042,7 +6042,6 @@ static enum stripe_result=20 >> make_stripe_request(struct mddev *mddev, >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 raid5_release_stripe(sh); >> =C2=A0 out: >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (ret =3D=3D STRIPE_SCHEDULE_AND_RETRY = &&=20 >> reshape_interrupted(mddev)) { >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bi->bi_status =3D BLK_STS_RE= SOURCE; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ret =3D STRIPE_WA= IT_RESHAPE; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pr_err_ratelimite= d("dm-raid456: io across reshape position=20 >> while reshape can't make progress"); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > > The link below leads to the same patch, which Kuai has already replied=20 > to. > > https://lore.kernel.org/all/20260203095156.2349174-1-yangxiuwei@kylinos.c= n/ Perhaps instead of clearing the error code from error path, this problem ca= n be fixed by resetting the error code from the issue path if original bio is resubmit= ted. > > > --=20 > Thanks, > Nan > > --=20 Thansk, Kuai