Re: [PATCH 1/2] mdadm: Respect config file location in man.

[Lukasz Florczak <lukasz.florczak@linux.intel.com>]

Dear Paul,
Thanks for reviewing my patch. 

On Tue, 15 Mar 2022 13:39:25 +0100, Paul Menzel <pmenzel@molgen.mpg.de>
wrote:

> Dear Lukasz,
> 
> 
> Thank you for your patches.
> 
> Am 15.03.22 um 09:55 schrieb Lukasz Florczak:
> 
> It’d be great if you removed the dot/period at the end of the git
> commit message summaries [1]. (Also in second patch.)

Noted.

> 
> > Default config file location could differ depending on OS (e.g.
> > Debian family).  
> 
> What is it an Debian?

Could you elaborate?

> 
>  [...]  
> 
> Looks like an independent fix. Please separate into a separate commit.

It's just adding a missing option. I don't think that it deserves a
separate commit. How about I will update the commit body to include
this particular change?

> 
> > +"  create, auto                                 used when creating
> > device names in /dev\n" +"  homehost, policy, part-policy
> >      used to guide policy in various\n" +"
> >                      situations\n" +"\n"
> > +"For more details see mdadm.conf(5).\n"
> >   "\n"
> >   ;
> >   
> > diff --git a/mdadm.8.in b/mdadm.8.in
> > index be902dba..d41b3ca7 100644
> > --- a/mdadm.8.in
> > +++ b/mdadm.8.in
> > @@ -267,13 +267,13 @@ the exact meaning of this option in different
> > contexts. .TP
> >   .BR \-c ", " \-\-config=
> >   Specify the config file or directory.  Default is to use
> > -.B /etc/mdadm.conf
> > +.B {CONFFILE}
> >   and
> > -.BR /etc/mdadm.conf.d ,
> > +.BR {CONFFILE}.d ,
> >   or if those are missing then
> > -.B /etc/mdadm/mdadm.conf
> > +.B {CONFFILE2}
> >   and
> > -.BR /etc/mdadm/mdadm.conf.d .
> > +.BR {CONFFILE2}.d .
> >   If the config file given is
> >   .B "partitions"
> >   then nothing will be read, but
> > @@ -2009,9 +2009,9 @@ The config file is only used if explicitly
> > named with or requested with (a possibly implicit)
> >   .BR \-\-scan .
> >   In the later case,
> > -.B /etc/mdadm.conf
> > +.B {CONFFILE}
> >   or
> > -.B /etc/mdadm/mdadm.conf
> > +.B {CONFFILE2}
> >   is used.
> >   
> >   If
> > @@ -3339,7 +3339,7 @@ uses this to find arrays when
> >   is given in Misc mode, and to monitor array reconstruction
> >   on Monitor mode.
> >   
> > -.SS /etc/mdadm.conf
> > +.SS {CONFFILE} (or {CONFFILE2})
> >   
> >   The config file lists which devices may be scanned to see if
> >   they contain MD super block, and gives identifying information
> > @@ -3347,7 +3347,7 @@ they contain MD super block, and gives
> > identifying information .BR mdadm.conf (5)
> >   for more details.
> >   
> > -.SS /etc/mdadm.conf.d
> > +.SS {CONFFILE}.d (or {CONFFILE2}.d)
> >   
> >   A directory containing configuration files which are read in
> > lexical order.
> > diff --git a/mdadm.conf.5 b/mdadm.conf.5.in
> > similarity index 99%
> > rename from mdadm.conf.5
> > rename to mdadm.conf.5.in
> > index 74a21c5f..83edd008 100644
> > --- a/mdadm.conf.5
> > +++ b/mdadm.conf.5.in
> > @@ -8,7 +8,7 @@
> >   .SH NAME
> >   mdadm.conf \- configuration for management of Software RAID with
> > mdadm .SH SYNOPSIS
> > -/etc/mdadm.conf
> > +{CONFFILE}
> >   .SH DESCRIPTION
> >   .PP
> >   .I mdadm  
> 
> The rest looks good.
> 
> 
> Kind regards,
> 
> Paul
> 
> 
> [1]: https://chris.beams.io/posts/git-commit/

Regards,

Lukasz