From: Jeff Mahoney <jeffm@suse.com>
To: Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
linux-raid@vger.kernel.org, song@kernel.org
Cc: nfbrown@suse.com, colyli@suse.com
Subject: Re: [PATCH] mdraid: fix read/write bytes accounting
Date: Tue, 23 Jun 2020 10:24:55 -0400 [thread overview]
Message-ID: <7d67e500-2365-d259-9938-72595cdb3c40@suse.com> (raw)
In-Reply-To: <ed552b4b-b19a-cc85-05f4-0a0dc0d6fac2@intel.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 700 bytes --]
On 6/8/20 3:13 AM, Artur Paszkiewicz wrote:
> On 6/5/20 10:19 PM, jeffm@suse.com wrote:
>> The i/o accounting published in /proc/diskstats for mdraid is currently
>> broken. md_make_request does the accounting for every bio passed but
>> when a bio needs to be split, all the split bios are also submitted
>> through md_make_request, resulting in multiple accounting.
>
> Hi Jeff,
>
> I sent a patch a few days ago which should fix this issue. Can you check
> it out?
>
> https://marc.info/?l=linux-raid&m=159102814820539
It scratches the same itch. I just didn't want to clone every bio just
to get stats.
-Jeff
--
Jeff Mahoney
Director, SUSE Labs Data & Performance
[-- Attachment #1.1.2: OpenPGP_0x1E7B4B632179E5B2.asc --]
[-- Type: application/pgp-keys, Size: 80367 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2020-06-23 14:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 20:19 [PATCH] mdraid: fix read/write bytes accounting jeffm
2020-06-08 7:13 ` Artur Paszkiewicz
2020-06-23 14:21 ` Guoqing Jiang
2020-06-23 16:48 ` Artur Paszkiewicz
2020-06-25 9:13 ` Guoqing Jiang
2020-06-23 14:24 ` Jeff Mahoney [this message]
2020-06-09 6:37 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d67e500-2365-d259-9938-72595cdb3c40@suse.com \
--to=jeffm@suse.com \
--cc=artur.paszkiewicz@intel.com \
--cc=colyli@suse.com \
--cc=linux-raid@vger.kernel.org \
--cc=nfbrown@suse.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox