From: NeilBrown <neilb@suse.com>
To: zhilong <zlliu@suse.com>, Jes.Sorensen@gmail.com
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 0/4] mdadm:checking level once mode has been set
Date: Mon, 13 Mar 2017 14:48:35 +1100 [thread overview]
Message-ID: <8737ehg7l8.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <65454fe3-6165-5d02-eecd-02f8aac8f422@suse.com>
[-- Attachment #1: Type: text/plain, Size: 855 bytes --]
On Mon, Mar 13 2017, zhilong wrote:
> On 03/13/2017 06:54 AM, NeilBrown wrote:
>> On Wed, Mar 08 2017, Zhilong Liu wrote:
>>
>>> mdadm: it would be better to check --level ealier,
>>> because it would fall to different prompt if user
>>> forgets to specify the --level. such as:
>>> ./mdadm -CR /dev/md0 -b internal -n2 -x1 /dev/loop[0-2]
>> When I run that command I get:
>>
>> mdadm: a RAID level is needed to create an array.
>>
>>
>> What do you get?
>
> I'm sorry I have provided the wrong command, for this scenario,
> issues "mdadm --build /dev/md0 -n2 /dev/loop[0-1]" should be
> proper. it's the purpose to check --level earlier.
OK, that makes sense.
>
> If this patch is useful, I would send the v1 patch for it, correct the
> comments.
My preference would be to have the check in Build.c, but Jes might have
different ideas.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-03-13 3:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 7:48 [PATCH 0/4] mdadm:checking level once mode has been set Zhilong Liu
2017-03-08 7:50 ` [PATCH 1/4] mdadm:bitmap cannot be set twice Zhilong Liu
2017-03-08 8:07 ` [PATCH 5/5] mdadm:checking level once mode has been set Zhilong Liu
2017-03-08 7:51 ` [PATCH 2/4] mdadm:external bitmap only supports ext filesystem Zhilong Liu
2017-03-12 14:48 ` Liu Zhilong
2017-03-13 8:16 ` zhilong
2017-03-08 7:52 ` [PATCH 3/4] mdadm:triggers core dump when stat2devnm return NULL Zhilong Liu
2017-03-12 23:00 ` NeilBrown
2017-03-13 5:34 ` zhilong
2017-03-13 7:01 ` [PATCH 3/4 v1] " Zhilong Liu
2017-03-12 22:54 ` [PATCH 0/4] mdadm:checking level once mode has been set NeilBrown
2017-03-13 3:22 ` zhilong
2017-03-13 3:48 ` NeilBrown [this message]
2017-03-13 5:16 ` zhilong
2017-03-17 19:30 ` jes.sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737ehg7l8.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=Jes.Sorensen@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=zlliu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).