From: NeilBrown <neilb@suse.de>
To: Shaohua Li <shli@fb.com>, linux-raid@vger.kernel.org
Subject: Re: [PATCH 1/2] raid5-cache: destroy mempool
Date: Wed, 06 Jan 2016 12:50:19 +1100 [thread overview]
Message-ID: <874merxyqs.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <9ab2f48aab9ddc9aa7ac2b9b6a594a97c2d82f5f.1451954517.git.shli@fb.com>
[-- Attachment #1: Type: text/plain, Size: 750 bytes --]
On Tue, Jan 05 2016, Shaohua Li wrote:
> io_unit mempool isn't destroied with recent changes.
>
> Signed-off-by: Shaohua Li <shli@fb.com>
> ---
> drivers/md/raid5-cache.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
> index d992d62..55a905e 100644
> --- a/drivers/md/raid5-cache.c
> +++ b/drivers/md/raid5-cache.c
> @@ -1257,6 +1257,7 @@ void r5l_exit_log(struct r5l_log *log)
> md_unregister_thread(&log->reclaim_thread);
> mempool_destroy(log->meta_pool);
> bioset_free(log->bs);
> + mempool_destroy(log->io_pool);
> kmem_cache_destroy(log->io_kc);
> kfree(log);
> }
Thanks!
I've merge that into the offending patch rather than adding it as a
separate patch.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
prev parent reply other threads:[~2016-01-06 1:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 0:43 [PATCH 1/2] raid5-cache: destroy mempool Shaohua Li
2016-01-05 0:43 ` [PATCH 2/2] raid5-cache: correctly handle stripe with enough journal space Shaohua Li
2016-01-06 1:54 ` NeilBrown
2016-01-06 1:55 ` Shaohua Li
2016-01-06 1:50 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874merxyqs.fsf@notabene.neil.brown.name \
--to=neilb@suse.de \
--cc=linux-raid@vger.kernel.org \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).