From: NeilBrown <nfbrown@novell.com>
To: Edward Kuns <eddie.kuns@gmail.com>,
Enrico Tagliavini <enrico.tagliavini@gmail.com>
Cc: Linux-RAID <linux-raid@vger.kernel.org>
Subject: Re: Reshape stalls and fails when SELinux is enabled
Date: Mon, 21 Dec 2015 12:50:29 +1100 [thread overview]
Message-ID: <877fk8604a.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <CACsGCyQX4DKfT-6CYd7pa8P-Rq12HhP2tA79F27rw1PbNHe_QQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1835 bytes --]
On Fri, Dec 11 2015, Edward Kuns wrote:
> I ran into this as well. I unwisely worked around it by placing the
> backup file on /tmp. I don't recommend that choice! I didn't see
> your AVC on your EMail, but I recommend you reach out to the SELinux
> folks for labeling help. I've reach out to them in the past and have
> found them very helpful (as are the folks here). Getting the labeling
> corrected will not only help you but everyone else in the long term.
>
> I agree that it would be good for mdadm to handle this kind of failure
> in a more productive fashion as well. But I'm only a lurker here. I
> don't have enough knowledge to suggest what would be better. One
> thing that really helped me debug this was commenting out the lines
>
> #StandardOutput=null
> #StandardError=null
>
> in the systemd file /lib/systemd/system/mdadm-grow-continue@.service
> -- note you have to run systemctl daemon-reload after changing the
> file for the change to be noticed.
>
> Once I did that, the system logs had much more useful information.
> I'm not sure where that file is sourced, whether it's from the
> linux-raid people or from the distributions or somewhere in between.
> Does anyone here know if there's a reason why standard out and
> standard error are sent to /dev/null for this service?
That mdadm-grow-continue@.service file is part of mdadm (in the systemd
directory).
As for why stdout/err is set to 'null', you could try finding out who
did that and ask them ....
http://git.neil.brown.name/?p=mdadm.git;a=commitdiff;h=5e76dce1acd906e8fc8af04973c3a129cdc77fd6
but I'm pretty sure that he has no idea.
You could try sending me a patch which changes those lines and gives some
sort of explanation why it is a good change to make.
There is a very good chance that I would apply that patch.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
prev parent reply other threads:[~2015-12-21 1:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 11:04 Reshape stalls and fails when SELinux is enabled Enrico Tagliavini
2015-12-10 9:00 ` Enrico Tagliavini
2015-12-10 17:06 ` Edward Kuns
2015-12-10 18:24 ` Wols Lists
2015-12-11 1:26 ` George Rapp
2015-12-11 14:26 ` Enrico Tagliavini
2015-12-21 1:50 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fk8604a.fsf@notabene.neil.brown.name \
--to=nfbrown@novell.com \
--cc=eddie.kuns@gmail.com \
--cc=enrico.tagliavini@gmail.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).