linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@gmail.com>
To: "Keld Jørn Simonsen" <keld@keldix.com>
Cc: Neil Brown <neilb@suse.de>, linux-raid@vger.kernel.org
Subject: Re: [PATCH v2 1/5] md/raid10: optimize read_balance() for 'far offset' arrays
Date: Wed, 15 Jun 2011 23:35:53 +0900	[thread overview]
Message-ID: <87aadj9n7a.fsf@gmail.com> (raw)
In-Reply-To: <1308140733.1358.41.camel@leonhard> (Namhyung Kim's message of "Wed, 15 Jun 2011 21:25:33 +0900")

Namhyung Kim <namhyung@gmail.com> writes:
> 2011-06-15 (수), 08:51 +0200, Keld Jørn Simonsen:
>> On Wed, Jun 15, 2011 at 11:02:00AM +0900, Namhyung Kim wrote:
>> > If @conf->far_offset > 0, there is only 1 stripe so that we can treat
>> > the array same as 'near' arrays.
>> 
>> does it also work with more than 2 copies - eg 3 copies?
>> I think the original code just takes the available data blocks with the 
>> lowest address.
>> 
>
> Hi,
>
> Let me clarify this: AFAIK, 'far offset' array saves redundant data in
> the diagonally adjacent chunk/disk, so it could be roughly thought as
> 'raid0' array with reduced size - just ignore redundant chunks here. It
> was my mistake considering it as 'near' array. :(
>

I'm confused again. If fo > 0 && fc > 1 && nc > 1 then it turns out to
a near array with reduced size, no? Does it still need to be treaded
as RAID0?


> Therefore, it makes more sense distributing reads over the array based
> on some criteria - here, the address of starting sector - like RAID0
> does. Now I see that the same goes to the 'far copies' array exactly, so
> the original code is correct.
>
> Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2011-06-15 14:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-15  2:01 [PATCH RESEND 0/5] md/raid10 changes Namhyung Kim
2011-06-15  2:02 ` [PATCH v2 1/5] md/raid10: optimize read_balance() for 'far offset' arrays Namhyung Kim
2011-06-15  2:57   ` NeilBrown
2011-06-15  6:51   ` Keld Jørn Simonsen
2011-06-15 12:25     ` Namhyung Kim
2011-06-15 14:35       ` Namhyung Kim [this message]
2011-06-15 23:56         ` NeilBrown
2011-06-15  2:02 ` [PATCH 2/5] md/raid10: get rid of duplicated conditional expression Namhyung Kim
2011-06-15  2:02 ` [PATCH 3/5] md/raid10: factor out common bio handling code Namhyung Kim
2011-06-15  2:02 ` [PATCH v2 4/5] md/raid10: share pages between read and write bio's during recovery Namhyung Kim
2011-06-15  2:02 ` [PATCH 5/5] md/raid10: spread read for subordinate r10bios " Namhyung Kim
2011-06-15  3:09   ` NeilBrown
2011-06-15  3:09 ` [PATCH RESEND 0/5] md/raid10 changes NeilBrown
2011-06-15  3:33   ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87aadj9n7a.fsf@gmail.com \
    --to=namhyung@gmail.com \
    --cc=keld@keldix.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).