[mdadm PATCH] mdadm: make create clustered raid10 possible

[mdadm PATCH] mdadm: make create clustered raid10 possible

[Guoqing Jiang]

This change to make we can create a clustered
raid10 array as well.

Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
---
 mdadm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mdadm.c b/mdadm.c
index 7cdcdba7c652..60d80e0103f4 100644
--- a/mdadm.c
+++ b/mdadm.c
@@ -1542,8 +1542,9 @@ int main(int argc, char *argv[])
 				break;
 			}
 
-			if (s.level != 1) {
-				pr_err("--bitmap=clustered is currently supported with RAID mirror only\n");
+			if (s.level != 1 && s.level != 10) {
+				pr_err("--bitmap=clustered is currently "
+				       "supported with raid1/10 only\n");
 				rv = 1;
 				break;
 			}
-- 
2.10.0

Re: [mdadm PATCH] mdadm: make create clustered raid10 possible

[NeilBrown]

[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]

On Tue, Oct 24 2017, Guoqing Jiang wrote:

> This change to make we can create a clustered
> raid10 array as well.
>
> Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
> ---
>  mdadm.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/mdadm.c b/mdadm.c
> index 7cdcdba7c652..60d80e0103f4 100644
> --- a/mdadm.c
> +++ b/mdadm.c
> @@ -1542,8 +1542,9 @@ int main(int argc, char *argv[])
>  				break;
>  			}
>  
> -			if (s.level != 1) {
> -				pr_err("--bitmap=clustered is currently supported with RAID mirror only\n");
> +			if (s.level != 1 && s.level != 10) {
> +				pr_err("--bitmap=clustered is currently "
> +				       "supported with raid1/10 only\n");


Please don't wrap strings.  It makes it hard to search for them.
Long line might be bad, but wrapped strings are worse.

Thanks,
NeilBrown


>  				rv = 1;
>  				break;
>  			}
> -- 
> 2.10.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: [mdadm PATCH] mdadm: make create clustered raid10 possible

[Jes Sorensen]

On 10/24/2017 04:05 PM, NeilBrown wrote:
> On Tue, Oct 24 2017, Guoqing Jiang wrote:
> 
>> This change to make we can create a clustered
>> raid10 array as well.
>>
>> Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
>> ---
>>   mdadm.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/mdadm.c b/mdadm.c
>> index 7cdcdba7c652..60d80e0103f4 100644
>> --- a/mdadm.c
>> +++ b/mdadm.c
>> @@ -1542,8 +1542,9 @@ int main(int argc, char *argv[])
>>   				break;
>>   			}
>>   
>> -			if (s.level != 1) {
>> -				pr_err("--bitmap=clustered is currently supported with RAID mirror only\n");
>> +			if (s.level != 1 && s.level != 10) {
>> +				pr_err("--bitmap=clustered is currently "
>> +				       "supported with raid1/10 only\n");
> 
> 
> Please don't wrap strings.  It makes it hard to search for them.
> Long line might be bad, but wrapped strings are worse.

Personally I actually prefer the wrapped strings over the long lines, 
but given the kernel consensus is not to wrap, I apply that rule to 
mdadm as well.

Cheers,
Jes

Re: [mdadm PATCH] mdadm: make create clustered raid10 possible

[Shaohua Li]

On Tue, Oct 24, 2017 at 03:31:24PM +0800, Guoqing Jiang wrote:
> This change to make we can create a clustered
> raid10 array as well.
> 
> Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
> ---
>  mdadm.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/mdadm.c b/mdadm.c
> index 7cdcdba7c652..60d80e0103f4 100644
> --- a/mdadm.c
> +++ b/mdadm.c
> @@ -1542,8 +1542,9 @@ int main(int argc, char *argv[])
>  				break;
>  			}
>  
> -			if (s.level != 1) {
> -				pr_err("--bitmap=clustered is currently supported with RAID mirror only\n");
> +			if (s.level != 1 && s.level != 10) {
> +				pr_err("--bitmap=clustered is currently "
> +				       "supported with raid1/10 only\n");
>  				rv = 1;
>  				break;

Since kernel only supports near layout for raid10 cluster, probably check the
layout in mdadm too?

Re: [mdadm PATCH] mdadm: make create clustered raid10 possible

[Guoqing Jiang]

On 10/30/2017 01:57 PM, Shaohua Li wrote:
> On Tue, Oct 24, 2017 at 03:31:24PM +0800, Guoqing Jiang wrote:
>> This change to make we can create a clustered
>> raid10 array as well.
>>
>> Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
>> ---
>>   mdadm.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/mdadm.c b/mdadm.c
>> index 7cdcdba7c652..60d80e0103f4 100644
>> --- a/mdadm.c
>> +++ b/mdadm.c
>> @@ -1542,8 +1542,9 @@ int main(int argc, char *argv[])
>>   				break;
>>   			}
>>   
>> -			if (s.level != 1) {
>> -				pr_err("--bitmap=clustered is currently supported with RAID mirror only\n");
>> +			if (s.level != 1 && s.level != 10) {
>> +				pr_err("--bitmap=clustered is currently "
>> +				       "supported with raid1/10 only\n");
>>   				rv = 1;
>>   				break;
> Since kernel only supports near layout for raid10 cluster, probably check the
> layout in mdadm too?

The changes in raid10_run has ensured only near layout is possible for 
clustered raid10.
Anyway, I will add the check either.

Thanks,
Guoqing