From: NeilBrown <neilb@suse.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-raid@vger.kernel.org, Shaohua Li <shli@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/6] md: Fine-tuning for some function implementations
Date: Wed, 03 May 2017 07:36:53 +1000 [thread overview]
Message-ID: <87efw7q6tm.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <f05bfc4e-7935-7e87-cc85-f0d9c5e3846a@users.sourceforge.net>
[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]
On Tue, May 02 2017, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 2 May 2017 16:12:34 +0200
>
> Some update suggestions were taken into account
> from static source code analysis.
>
> Markus Elfring (6):
> Replace seven seq_printf() calls by seq_putc()
> Replace 17 seq_printf() calls by seq_puts()
Why does anyone care whether printf or putc/puts is used? Really it
doesn't matter *at* *all*.
I don't object to the patch but if it would up to me I probably wouldn't
bother applying it it either.
Sometimes I just want to "print" something and I don't want to care
whether it is a constant string or a single-byte constant string, or
something more general.
I see these changes as worse than white-space fixes.
NeilBrown
> Adjust four function calls together with a variable assignment
> Use seq_puts() in faulty_status()
> Adjust six function calls together with a variable assignment in faulty_status()
> Add some spaces for better code readability
>
> drivers/md/faulty.c | 48 ++++++++++++++++++++++----------------
> drivers/md/md.c | 66 +++++++++++++++++++++++++++++------------------------
> 2 files changed, 64 insertions(+), 50 deletions(-)
>
> --
> 2.12.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-05-02 21:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 14:23 [PATCH 0/6] md: Fine-tuning for some function implementations SF Markus Elfring
2017-05-02 14:25 ` [PATCH 1/6] md: Replace seven seq_printf() calls by seq_putc() SF Markus Elfring
2017-05-02 14:26 ` [PATCH 2/6] md: Replace 17 seq_printf() calls by seq_puts() SF Markus Elfring
2017-05-02 14:27 ` [PATCH 3/6] md: Adjust four function calls together with a variable assignment SF Markus Elfring
2017-05-02 14:28 ` [PATCH 4/6] md: Use seq_puts() in faulty_status() SF Markus Elfring
2017-05-02 14:29 ` [PATCH 5/6] md: Adjust six function calls together with a variable assignment " SF Markus Elfring
2017-05-02 14:31 ` [PATCH 6/6] md: Add some spaces for better code readability SF Markus Elfring
2017-05-02 21:36 ` NeilBrown [this message]
2017-05-03 7:38 ` [PATCH 0/6] md: Fine-tuning for some function implementations Nikola Pajkovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efw7q6tm.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).