From: NeilBrown <neilb@suse.com>
To: Robert LeBlanc <robert@leblancnet.us>, linux-raid@vger.kernel.org
Subject: Re: [PATCH 1/2] md/raid1: Refactor raid1_make_request
Date: Fri, 02 Dec 2016 11:36:35 +1100 [thread overview]
Message-ID: <87eg1r6ub0.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <20161130212020.15762-2-robert@leblancnet.us>
[-- Attachment #1: Type: text/plain, Size: 829 bytes --]
On Thu, Dec 01 2016, Robert LeBlanc wrote:
> Refactor raid1_make_request to make read and write code in their own
> functions to clean up the code.
There is a change in here that is more than just a refactoring.
You have moved the wait_barrier() call from after the checks on
->suspend_{lo,hi} to before.
If a write was sent to a suspended region, this will block any pending
resync until the suspended region is moved.
The previous code won't block resync in this case.
I cannot see that this would actually have any practical significance,
as I don't think the suspend_hi/lo settings are used at all for raid1.
I'm less certain about the ->area_resyncing() test, though that probably
isn't a problem.
But it should at least be noted in the change-log that there is
potentially a functional change here.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2016-12-02 0:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 21:20 [PATCH 0/2] Reorganize raid*_make_request to clean up code Robert LeBlanc
2016-11-30 21:20 ` [PATCH 1/2] md/raid1: Refactor raid1_make_request Robert LeBlanc
2016-12-01 16:04 ` John Stoffel
2016-12-01 17:40 ` Robert LeBlanc
2016-12-01 22:00 ` John Stoffel
2016-12-02 0:36 ` NeilBrown [this message]
2016-11-30 21:20 ` [PATCH 2/2] md/raid10: Refactor raid10_make_request Robert LeBlanc
2016-12-02 3:30 ` [PATCH v2 0/2] Reorganize raid*_make_request to clean up code Robert LeBlanc
2016-12-02 3:30 ` [PATCH v2 1/2] md/raid1: Refactor raid1_make_request Robert LeBlanc
2016-12-02 3:30 ` [PATCH v2 2/2] md/raid10: Refactor raid10_make_request Robert LeBlanc
2016-12-02 22:02 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg1r6ub0.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=linux-raid@vger.kernel.org \
--cc=robert@leblancnet.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).