Re: [PATCH 3/8] Grow: Grow_continue_command() remove dead code

[NeilBrown <neilb@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

On Wed, Mar 09 2016, Jes.Sorensen@redhat.com wrote:

> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> All cases where fd2 is used are completed with a close(fd2) ; fd2 = -1;
> so there is no need to check for fd2 > -1 before exiting.

In that case, you can remove all the assignments so -1 to fd2 - if you
like.

Thanks,
NeilBrown

>
> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
> ---
>  Grow.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/Grow.c b/Grow.c
> index c4f417e..0fa776d 100755
> --- a/Grow.c
> +++ b/Grow.c
> @@ -4924,8 +4924,6 @@ int Grow_continue_command(char *devname, int fd,
>  	ret_val = Grow_continue(fd, st, content, backup_file, 1, 0);
>  
>  Grow_continue_command_exit:
> -	if (fd2 > -1)
> -		close(fd2);
>  	if (cfd > -1)
>  		close(cfd);
>  	st->ss->free_super(st);
> -- 
> 2.5.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]