Re: A sector-of-mismatch warning patch (was Re: Fault tolerance with badblocks)

[NeilBrown <neilb@suse.com>]

[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]

On Tue, May 16 2017, Nix wrote:

> On 16 May 2017, NeilBrown spake thusly:
>
>> Actually, I have another caveat.  I don't think we want these messages
>> during initial resync, or any resync.  Only during a 'check' or
>> 'repair'.
>> So add a check for MD_RECOVERY_REQUESTED or maybe for
>>   sh->sectors >= conf->mddev->recovery_cp
>
> I completely agree, but it's already inside MD_RECOVERY_CHECK:
>
> if (test_bit(MD_RECOVERY_CHECK, &conf->mddev->recovery)) {
>         /* don't try to repair!! */
>         set_bit(STRIPE_INSYNC, &sh->state);
>         pr_warn_ratelimited("%s: mismatch sector in range "
>                             "%llu-%llu\n", mdname(conf->mddev),
>                             (unsigned long long) sh->sector,
>                             (unsigned long long) sh->sector +
>                             STRIPE_SECTORS);
> } else {
>
> Doesn't that already mean that someone has explicitly triggered a check
> action?

Uhmm... yeah.  I lose track of which flags me what exactly.
You log messages aren't generated when 'repair' is used, only when
'check' is.
I can see why you might have chosen that, but I wonder if it is best.

But I'm OK with this patch as it stands.

NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]