From: NeilBrown <neilb@suse.com>
To: Shaohua Li <shli@kernel.org>, linux-raid@vger.kernel.org
Cc: Shaohua Li <shli@fb.com>
Subject: Re: [PATCH 0/3] md: retry bailed bio
Date: Thu, 28 Sep 2017 12:47:41 +1000 [thread overview]
Message-ID: <87ing35yk2.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <cover.1506015297.git.shli@fb.com>
[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]
On Thu, Sep 21 2017, Shaohua Li wrote:
> From: Shaohua Li <shli@fb.com>
>
> With cc27b0c78c79(md: fix deadlock between mddev_suspend() and
> md_write_start()), pers->make_request could bail out without handling the bio.
> If that happens, we should retry. There are two call sites we don't do the
> retry and cause problems. This set fixes the issues.
All look good to me, thanks.
Reviewed-by: NeilBrown <neilb@suse.com>
NeilBrown
>
> Thanks,
> Shaohua
>
> Shaohua Li (3):
> md: separate request handling
> md: fix a race condition for flush request handling
> dm-raid: fix a race condition in request handling
>
> drivers/md/dm-raid.c | 2 +-
> drivers/md/md.c | 72 +++++++++++++++++++++++++++++++---------------------
> drivers/md/md.h | 1 +
> 3 files changed, 45 insertions(+), 30 deletions(-)
>
> --
> 2.11.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2017-09-28 2:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 17:42 [PATCH 0/3] md: retry bailed bio Shaohua Li
2017-09-21 17:42 ` [PATCH 1/3] md: separate request handling Shaohua Li
2017-09-21 17:42 ` [PATCH 2/3] md: fix a race condition for flush " Shaohua Li
2017-09-21 17:42 ` [PATCH 3/3] dm-raid: fix a race condition in " Shaohua Li
2017-09-28 2:47 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ing35yk2.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=linux-raid@vger.kernel.org \
--cc=shli@fb.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).