From: Neil Brown <neilb@suse.de>
To: Bart Van Assche <bart.vanassche@sandisk.com>, Shaohua Li <shli@fb.com>
Cc: linux-raid@vger.kernel.org, Kernel-team@fb.com,
songliubraving@fb.com, hch@infradead.org
Subject: Re: [PATCH] raid5-cache: use crc32c checksum
Date: Fri, 30 Oct 2015 17:37:49 +1100 [thread overview]
Message-ID: <87io5ox3nm.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <56315032.7070904@sandisk.com>
[-- Attachment #1: Type: text/plain, Size: 473 bytes --]
On Thu, Oct 29 2015, Bart Van Assche wrote:
> On 10/28/2015 08:41 AM, Shaohua Li wrote:
>> crc32c has lower overhead with cpu acceleration. It's a shame I didn't
>> use it in first post, sorry. This changes disk format, but we are still
>> ok in current stage.
>>
>> V2: delete unnecessary type conversion as pointed out by Bart
>
> Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Thanks. I've applied the second version and added your reviewed-by.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
prev parent reply other threads:[~2015-10-30 6:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 23:48 [PATCH] raid5-cache: use crc32c checksum Shaohua Li
2015-10-28 15:26 ` Bart Van Assche
2015-10-28 15:41 ` Shaohua Li
2015-10-28 22:46 ` Bart Van Assche
2015-10-30 6:37 ` Neil Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87io5ox3nm.fsf@notabene.neil.brown.name \
--to=neilb@suse.de \
--cc=Kernel-team@fb.com \
--cc=bart.vanassche@sandisk.com \
--cc=hch@infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=shli@fb.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).