From: Neil Brown <neilb@suse.de>
To: Song Liu <songliubraving@fb.com>
Cc: Shaohua Li <shli@fb.com>, linux-raid@vger.kernel.org
Subject: RE: [PATCH v2 0/6] mdadm support for journal device of RAID-4/5/6
Date: Mon, 19 Oct 2015 13:11:40 +1100 [thread overview]
Message-ID: <87lhazli8z.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <C709E4D363AAB64590BFAC54D4C478AA0104B94E0A@PRN-MBX02-4.TheFacebook.com>
[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]
Song Liu <songliubraving@fb.com> writes:
> Hi Neil,
>
> Could you please share some insights about kernel and mdadm patches for
> journal device in RAID-4/5/6? What shall we do next to move this approach
> ahead?
I hadn't been looking at the mdadm patches until I was fairly
comfortable with the kernel code. I think we have reached that state
now and I have just looked at your mdadm patches.
These seem quite sensible and thorough - thanks. I have applied them to
by 'master' branch.
Would you be able to write a few test scripts to go in the 'tests'
directory?
Some of your changelog comment demonstrated how some commands would work
and others would give useful error messages. If there were test scripts
which confirmed the code continues to do that (and maybe more) that
would be great.
Also a section of the md.4 man page (similar to "BITMAP WRITE-INTENT
LOGGING" and "BAD BLOCK LIST") which gave a general outline of the
purpose, value, and possible costs, of using a journal would be really
helpful.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
prev parent reply other threads:[~2015-10-19 2:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 5:51 [PATCH v2 0/6] mdadm support for journal device of RAID-4/5/6 Song Liu
2015-10-09 5:51 ` [PATCH v2 1/6] add macros for MD_DISK_ROLE_(SPARE/FAULTY) Song Liu
2015-10-09 5:51 ` [PATCH v2 2/6] Show device as journal in --detail --examine Song Liu
2015-10-09 5:51 ` [PATCH v2 3/6] Enable create array with write journal (--write-journal DEVICE) Song Liu
2015-10-09 5:51 ` [PATCH v2 4/6] Assemble array with write journal Song Liu
2015-10-09 5:51 ` [PATCH v2 5/6] Check write journal in incremental Song Liu
2015-10-09 5:51 ` [PATCH v2 6/6] Add help message and man entry for --write-journal Song Liu
[not found] ` <C709E4D363AAB64590BFAC54D4C478AA0104B94E0A@PRN-MBX02-4.TheFacebook.com>
2015-10-19 2:11 ` Neil Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhazli8z.fsf@notabene.neil.brown.name \
--to=neilb@suse.de \
--cc=linux-raid@vger.kernel.org \
--cc=shli@fb.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).