Re: [PATCH] Fix wrong description in manpage

[NeilBrown <neilb@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1941 bytes --]

On Wed, Jan 13 2016, Guoqing Jiang wrote:

> The careless change was introduce by 'commit 7e6e839a2651
> (mdadm: change the num of cluster node)'. Which should be
> revert to avoid misunderstanding.
>
> Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
> ---
>  mdadm.8.in | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mdadm.8.in b/mdadm.8.in
> index 2844039..c2f2c95 100644
> --- a/mdadm.8.in
> +++ b/mdadm.8.in
> @@ -1162,9 +1162,7 @@ is given, a random UUID is chosen.
>  The
>  .B name
>  option will change the
> -.I name
> -of the array as stored in the superblock and bitmap. This option only
> -works for clustered environment.
> +.I name.
>  
>  The
>  .B nodes

Thanks, that patch was messed up.
However your patch only fixes part of the mess that was made.
I've changed it to the following.

Thanks,
NeilBrown


From: Guoqing Jiang <gqjiang@suse.com>
Date: Tue, 12 Jan 2016 18:08:24 +0300
Subject: [PATCH] Fix wrong description in manpage

The careless change was introduce by 'commit 7e6e839a2651
(mdadm: change the num of cluster node)'. Which should be
revert to avoid misunderstanding.

Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
Signed-off-by: NeilBrown <neilb@suse.com>

diff --git a/mdadm.8.in b/mdadm.8.in
index 2844039584ac..97ce8dc8219b 100644
--- a/mdadm.8.in
+++ b/mdadm.8.in
@@ -1163,15 +1163,15 @@ The
 .B name
 option will change the
 .I name
-of the array as stored in the superblock and bitmap. This option only
-works for clustered environment.
+of the array as stored in the superblock.  This is only supported for
+version-1 superblocks.
 
 The
 .B nodes
 option will change the
 .I nodes
-of the array as stored in the superblock.  This is only supported for
-version-1 superblocks.
+of the array as stored in the bitmap superblock. This option only
+works for a clustered environment.
 
 The
 .B homehost

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]