linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.com>
To: John Stoffel <john@stoffel.org>
Cc: "jes.sorensen@gmail.com" <jes.sorensen@gmail.com>,
	Linux Raid <linux-raid@vger.kernel.org>
Subject: Re: [mdadm PATCH] mdopen: call "modprobe md_mod" if it might be needed.
Date: Tue, 26 Sep 2017 09:50:06 +1000	[thread overview]
Message-ID: <87poae72z5.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <22985.8214.251962.72926@quad.stoffel.home>

[-- Attachment #1: Type: text/plain, Size: 2480 bytes --]

On Mon, Sep 25 2017, John Stoffel wrote:

>>>>>> "NeilBrown" == NeilBrown  <neilb@suse.com> writes:
>
> NeilBrown> Creating an array by opening a block-device with major number of 9
> NeilBrown> will transparently load the md module if needed.
> NeilBrown> Creating an array by opening
> NeilBrown>    /sys/module/md_mod/parameters/new_array
> NeilBrown> and writing to it won't, it will just fail if md_mod isn't loaded.
>
> NeilBrown> So when opening that file fails with ENOENT, run "modprobe md_mod" and
> NeilBrown> try again.
>
> NeilBrown> This fixes a bug whereby if you have "CREATE names=yes" in mdadm.conf,
> NeilBrown> and the md modules isn't loaded, then creating or assembling an
> NeilBrown> array will not honor the "names=yes" configuration.
>
> NeilBrown> Signed-off-by: NeilBrown <neilb@suse.com>
> NeilBrown> ---
> NeilBrown>  mdopen.c | 4 ++++
> NeilBrown>  1 file changed, 4 insertions(+)
>
> NeilBrown> diff --git a/mdopen.c b/mdopen.c
> NeilBrown> index 3c0052f2db23..dcdc6f23e6c1 100644
> NeilBrown> --- a/mdopen.c
> NeilBrown> +++ b/mdopen.c
> NeilBrown> @@ -312,6 +312,10 @@ int create_mddev(char *dev, char *name, int autof, int trustworthy,
> NeilBrown>  		if (block_udev)
> NeilBrown>  			udev_block(devnm);
> NeilBrown>  		fd = open("/sys/module/md_mod/parameters/new_array", O_WRONLY);
> NeilBrown> +		if (fd < 0 && errno == ENOENT) {
> NeilBrown> +			system("modprobe md_mod");
> NeilBrown> +			fd = open("/sys/module/md_mod/parameters/new_array", O_WRONLY);
> NeilBrown> +		}
> NeilBrown>  		if (fd >= 0) {
> NeilBrown>  			n = write(fd, devnm, strlen(devnm));
> NeilBrown>  			close(fd);
> NeilBrown> -- 
> NeilBrown> 2.14.0.rc0.dirty
>
> I haven't looked, but shouldn't the path for modprobe be hardcoded
> here to /sbin/modprobe?  Or the PATH sanitized so that random people
> can't put something into the system PATH and cause problems? 

That issue briefly crossed my mind as I wrote the code (is it OK to use
system()? should I use /sbin/modprobe or just modprobe?) but as mdadm is
not set-uid and cannot be run in an environment created by a
non-privileged user, there is no security risk.
Certainly a careless sysadmin might set path wrongs, but the most likely
wrong outcome is that modprobe won't be found, and there is very little
cost to that.

So thanks for asking, but I don't think there is any need for any extra
care, in which case "simplest is best".

Thanks,
NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2017-09-25 23:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-25  5:52 [mdadm PATCH] mdopen: call "modprobe md_mod" if it might be needed NeilBrown
2017-09-25 15:26 ` John Stoffel
2017-09-25 23:50   ` NeilBrown [this message]
2017-09-26 15:11     ` Jes Sorensen
2017-09-26 19:12       ` Wols Lists
2017-09-26 20:55         ` John Stoffel
2017-09-27 21:30 ` Jes Sorensen
     [not found] ` <cba5f77f-d6de-7a6b-35b0-70b7c56eb3f7@suse.com>
2017-10-10 20:16   ` NeilBrown
2017-10-11  7:39     ` Zhilong Liu
2017-10-12  0:06       ` NeilBrown
2017-10-12  3:55         ` Zhilong Liu
2017-10-12  8:48           ` NeilBrown
2017-10-13  9:16             ` Zhilong Liu
2017-10-15 22:41               ` NeilBrown
2017-10-12  9:55         ` Wols Lists

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87poae72z5.fsf@notabene.neil.brown.name \
    --to=neilb@suse.com \
    --cc=jes.sorensen@gmail.com \
    --cc=john@stoffel.org \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).