From: NeilBrown <neilb@suse.com>
To: linux-nvdimm@lists.01.org
Cc: Vishal Verma <vishal.l.verma@intel.com>,
linux-block@vger.kernel.org, linux-raid@vger.kernel.org,
linux-scsi@vger.kernel.org, Jens Axboe <axboe@fb.com>,
Jeff Moyer <jmoyer@redhat.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH v4 0/3] Badblock tracking for gendisks
Date: Wed, 09 Dec 2015 07:30:38 +1100 [thread overview]
Message-ID: <87poygsmxd.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <1449602295-28781-1-git-send-email-vishal.l.verma@intel.com>
[-- Attachment #1: Type: text/plain, Size: 572 bytes --]
On Wed, Dec 09 2015, Vishal Verma <vishal.l.verma@intel.com> wrote:
>
> Patch 3 converts md over to use the new badblocks 'library'. I have
> done some pretty simple testing on this - created a raid 1 device,
> made sure the sysfs entries show up, and can be used to add and view
> badblocks. A closer look by the md folks would be nice here.
Hi,
this all looks reasonably sensible. I haven't gone over it with a
fine toothed comb (I wonder where that analogy comes from....) but
nothing is obviously wrong.
Acked-by: NeilBrown <neilb@suse.com>
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2015-12-08 20:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 19:18 [PATCH v4 0/3] Badblock tracking for gendisks Vishal Verma
2015-12-08 19:18 ` [PATCH v4 1/3] badblocks: Add core badblock management code Vishal Verma
2015-12-08 19:18 ` [PATCH v4 2/3] block: Add badblock management for gendisks Vishal Verma
2015-12-08 19:18 ` [PATCH v4 3/3] md: convert to use the generic badblocks code Vishal Verma
2015-12-08 20:30 ` NeilBrown [this message]
2015-12-08 21:52 ` [PATCH v4 0/3] Badblock tracking for gendisks Finn Thain
2015-12-11 5:40 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87poygsmxd.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@fb.com \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).