From: NeilBrown <neilb@suse.com>
To: Peter Rajnoha <prajnoha@redhat.com>,
Jes Sorensen <jes.sorensen@gmail.com>
Cc: linux-raid@vger.kernel.org, dm-devel@redhat.com
Subject: [mdadm PATCH] Fix typo in new udev rule.
Date: Fri, 05 May 2017 15:16:15 +1000 [thread overview]
Message-ID: <87r303opcw.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <85c9e9e1-3d2c-9f88-e923-235fb69a4188@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1492 bytes --]
As pointed out by Peter Rajnoha, the correct usage in udev is
TEST=="file", not TEST="file".
Also improve a related comment which was a bit informal.
Reported-by: Peter Rajnoha <prajnoha@redhat.com>
Fixes: cd6cbb08c458 ("Create: tell udev md device is not ready when first created.")
Signed-off-by: NeilBrown <neilb@suse.com>
---
Thanks Peter! Properly tested as well :-)
NeilBrown
lib.c | 2 +-
udev-md-raid-creating.rules | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib.c b/lib.c
index 7e44b1f27fcc..be093e8c30cb 100644
--- a/lib.c
+++ b/lib.c
@@ -165,7 +165,7 @@ char *fd2devnm(int fd)
/* When we create a new array, we don't want the content to
* be immediately examined by udev - it is probably meaningless.
- * So create /run/mdadm/creating-FOO and expect that a udev
+ * So create /run/mdadm/creating-mdXXX and expect that a udev
* rule will noticed this and act accordingly.
*/
static char block_path[] = "/run/mdadm/creating-%s";
diff --git a/udev-md-raid-creating.rules b/udev-md-raid-creating.rules
index 2be466bcefd2..9bef8d1103f5 100644
--- a/udev-md-raid-creating.rules
+++ b/udev-md-raid-creating.rules
@@ -4,4 +4,4 @@
# the array is not "ready" and we should make sure the
# content is ignored.
-KERNEL=="md*", TEST="/run/mdadm/creating-$kernel", ENV{SYSTEMD_READY}="0"
+KERNEL=="md*", TEST=="/run/mdadm/creating-$kernel", ENV{SYSTEMD_READY}="0"
--
2.12.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-05-05 5:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 2:40 [mdadm PATCH 0/4] Assorted mdadm patches NeilBrown
2017-04-20 2:40 ` [mdadm PATCH 1/4] Grow_continue_command: ensure 'content' is properly initialised NeilBrown
2017-04-20 16:56 ` Jes Sorensen
2017-04-20 2:40 ` [mdadm PATCH 2/4] systemd/mdadm-last-resort: use ConditionPathExists instead of Conflicts NeilBrown
2017-04-20 16:57 ` Jes Sorensen
2017-04-20 2:40 ` [mdadm PATCH 3/4] Detail: ensure --export names are acceptable as shell variables NeilBrown
2017-04-20 16:59 ` Jes Sorensen
2017-04-20 2:40 ` [mdadm PATCH 4/4] Create: tell udev device is not ready when first created NeilBrown
2017-04-20 17:29 ` Jes Sorensen
2017-04-20 21:35 ` NeilBrown
2017-04-26 10:19 ` Peter Rajnoha
2017-04-28 3:55 ` NeilBrown
2017-04-28 9:08 ` Peter Rajnoha
2017-05-01 4:35 ` [dm-devel] " NeilBrown
2017-05-02 11:40 ` Peter Rajnoha
2017-05-02 13:40 ` Jes Sorensen
2017-05-03 14:27 ` Peter Rajnoha
2017-05-03 14:41 ` Jes Sorensen
2017-05-02 21:42 ` NeilBrown
2017-04-28 5:05 ` [mdadm PATCH] Create: tell udev md " NeilBrown
2017-04-28 9:28 ` Peter Rajnoha
2017-05-02 13:32 ` Jes Sorensen
2017-05-03 14:13 ` Peter Rajnoha
2017-05-03 14:44 ` Jes Sorensen
2017-05-06 16:25 ` Wols Lists
2017-05-06 19:50 ` Phil Turmel
2017-05-09 11:57 ` Peter Rajnoha
2017-05-09 12:14 ` Peter Rajnoha
2017-05-02 13:42 ` Jes Sorensen
2017-05-03 14:32 ` Peter Rajnoha
2017-05-03 14:45 ` [dm-devel] " Jes Sorensen
2017-05-04 10:58 ` Peter Rajnoha
2017-05-05 5:16 ` NeilBrown [this message]
2017-05-05 15:07 ` [mdadm PATCH] Fix typo in new udev rule Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r303opcw.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=dm-devel@redhat.com \
--cc=jes.sorensen@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=prajnoha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).