From: NeilBrown <neilb@suse.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Shaohua Li <shli@kernel.org>, linux-raid@vger.kernel.org
Subject: Re: [md PATCH 2/4] md: add bio completion tracing for raid1/raid10
Date: Thu, 17 Nov 2016 16:35:47 +1100 [thread overview]
Message-ID: <87r36ahdn0.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <20161116143233.GA28615@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 992 bytes --]
On Thu, Nov 17 2016, Christoph Hellwig wrote:
> On Mon, Nov 14, 2016 at 04:30:21PM +1100, NeilBrown wrote:
>> raid5 already has this, as does dm.
>> linear and raid0 do no see completions, only bio_chain_end() or bio_endio()
>> see those.
>> So just add it for raid1 and raid10.
>>
>> Between
>> Commit: 3a366e614d08 ("block: add missing block_bio_complete() tracepoint")
>> and
>> Commit: 0a82a8d132b2 ("Revert "block: add missing block_bio_complete() tracepoint"")
>> in the 3.9-rc series, this was done centrally in bio_endio().
>> Until/unless that is resurected, do the tracing in the md/raid code.
>
> We're working on getting it back for 4.10, so please don't add these
> tracepoints to the MD driver for now. Next time please also ask
> linux-block first and/or Cc the list on a patch like this.
Oh good, thanks for letting me know. I'll drop that one.
Do you know if there is any plan to include trace_block_split() in
bio_split()??
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]
next prev parent reply other threads:[~2016-11-17 5:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 5:30 [md PATCH 0/4] Improve blktrace tracing of md NeilBrown
2016-11-14 5:30 ` [md PATCH 2/4] md: add bio completion tracing for raid1/raid10 NeilBrown
2016-11-16 14:32 ` Christoph Hellwig
2016-11-17 5:35 ` NeilBrown [this message]
2016-11-17 12:51 ` Christoph Hellwig
2016-11-14 5:30 ` [md PATCH 3/4] md/bitmap: add blktrace event for writes to the bitmap NeilBrown
2016-11-16 19:31 ` Shaohua Li
2016-11-14 5:30 ` [md PATCH 4/4] md/raid1, raid10: add blktrace records when IO is delayed NeilBrown
2016-11-14 5:30 ` [md PATCH 1/4] md: add block tracing for bio_remapping NeilBrown
2016-11-16 19:29 ` Shaohua Li
2016-11-17 5:33 ` NeilBrown
2016-11-17 18:04 ` Shaohua Li
2016-11-18 0:45 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r36ahdn0.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=hch@infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).