linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.com>
To: V <viswesh.vichu@gmail.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: Resync issue in RAID1
Date: Fri, 28 Oct 2016 17:01:06 +1100	[thread overview]
Message-ID: <87r371rp0d.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <CAF9xHmQfUDOYFNa1uehqsz=arx-x24DuavX1sdBY313mdt0GEw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3402 bytes --]

On Fri, Oct 28 2016, V wrote:

> Hi Neil,
>
> Thanks for the response. But during this phase, why is the scsi driver
> complaining about bad block number ?
>
> Oct 18 03:52:56  kernel: [  52.869378] sd 0:0:0:0: [sda] Bad block
> number requested

Because md is asking to read blocks are offsets which are not a multiple
of 8 sectors.

NeilBrown


> Oct 18 03:52:56  kernel: [  52.869414] sd 0:0:0:0: [sda] Bad block
> number requested
> Oct 18 03:52:56  kernel: [  52.869436] sd 0:0:0:0: [sda] Bad block
> number requested
> Oct 18 03:52:56  kernel: [  52.869465] sd 0:0:0:0: [sda] Bad block
> number requested
> Oct 18 03:52:56  kernel: [  52.869503] sd 0:0:1:0: [sdb] Bad block
> number requested
>
> Thanks,
> V
>
> On Thu, Oct 27, 2016 at 9:01 PM, NeilBrown <neilb@suse.com> wrote:
>> On Sat, Oct 22 2016, V wrote:
>>
>>> Hi,
>>>
>>> I am facing an issue during RAID1 resync. I have an ubuntu
>>> 4.4.0-31-generic running with raid1 configured with 2 disks as active
>>> and 2 as spares. On the first powercycle, after installing RAID, i see
>>> the following messages in kern.log
>>>
>>>
>>> My disks are configured with 4K sector size (both logical and
>>> physical) (sda and sdb are active disks for this raid)
>>>
>>>
>>> ===========
>>> Oct 18 03:52:56  kernel: [   52.869113] md: using 128k window, over a
>>> total of 51167104k.
>>> Oct 18 03:52:56  kernel: [   52.869114] md: resuming resync of md2 from checkpoint.
>>
>> This line (above) combined with ...
>>
>>> Oct 18 03:52:56  kernel: [   52.869536] md/raid1:md2: sda: unrecoverable I/O read error for block 3
>>
>> this line suggests that when you shut down, md had already started a
>> resync, and it had checkpointed at block '3'.
>>
>> The subsequent error are:
>>
>>> Oct 18 03:52:56  kernel: [   52.869692] md/raid1:md2: sda: unrecoverable I/O read error for block 131
>>> Oct 18 03:52:56  kernel: [   52.869837] md/raid1:md2: sda: unrecoverable I/O read error for block 259
>>> Oct 18 03:52:56  kernel: [   52.870022] md/raid1:md2: sda: unrecoverable I/O read error for block 387
>>
>> which are every 128 blocks (aka sectors) from '3'.
>> I know what caused that.  The patch below will stop it happening again.
>>
>> You might be able get your array working again by stopping it
>> and assembling with --update=resync.
>> That will reset the checkpoint to 0.
>>
>> NeilBrown
>>
>> diff --git a/drivers/md/md.c b/drivers/md/md.c
>> index 2cf0e1c00b9a..aa2ca23463f4 100644
>> --- a/drivers/md/md.c
>> +++ b/drivers/md/md.c
>> @@ -8099,7 +8099,8 @@ void md_do_sync(struct md_thread *thread)
>>             mddev->curr_resync > 2) {
>>                 if (test_bit(MD_RECOVERY_SYNC, &mddev->recovery)) {
>>                         if (test_bit(MD_RECOVERY_INTR, &mddev->recovery)) {
>> -                               if (mddev->curr_resync >= mddev->recovery_cp) {
>> +                               if (mddev->curr_resync >= mddev->recovery_cp &&
>> +                                   mddev->curr_resync > 3) {
>>                                         printk(KERN_INFO
>>                                                "md: checkpointing %s of %s.\n",
>>                                                desc, mdname(mddev));
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]

  reply	other threads:[~2016-10-28  6:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21 15:53 Resync issue in RAID1 V
2016-10-28  4:01 ` NeilBrown
2016-10-28  5:33   ` V
2016-10-28  6:01     ` NeilBrown [this message]
2016-10-28  6:07       ` V
2016-11-04  3:33         ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r371rp0d.fsf@notabene.neil.brown.name \
    --to=neilb@suse.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=viswesh.vichu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).