From: Neil Brown <neilb@suse.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Shaohua Li <shli@fb.com>,
Bart Van Assche <bart.vanassche@sandisk.com>,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] raid5-cache: add crc32c Kconfig dependency
Date: Fri, 06 Nov 2015 14:19:11 +1100 [thread overview]
Message-ID: <87si4jak7k.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <4308930.z8rrqMJU90@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
On Wed, Nov 04 2015, Arnd Bergmann wrote:
> The recent change of the raid5-cache code to use crc32c instead
> of crc32 causes link errors when CONFIG_LIBCRC32C is disabled:
>
> drivers/built-in.o: In function crc32c'
> core.c:(.text+0x1c6060): undefined reference to `crc32c'
>
> This adds an explicit 'select' statement like all other users
> of this function do.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 5cb2fbd6ea0d ("raid5-cache: use crc32c checksum")
>
> diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
> index 3e01e6fb3424..7913fdcfc849 100644
> --- a/drivers/md/Kconfig
> +++ b/drivers/md/Kconfig
> @@ -123,6 +123,7 @@ config MD_RAID456
> tristate "RAID-4/RAID-5/RAID-6 mode"
> depends on BLK_DEV_MD
> select RAID6_PQ
> + select LIBCRC32C
> select ASYNC_MEMCPY
> select ASYNC_XOR
> select ASYNC_PQ
Applied, thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
prev parent reply other threads:[~2015-11-06 3:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 14:12 [PATCH] raid5-cache: add crc32c Kconfig dependency Arnd Bergmann
2015-11-06 3:19 ` Neil Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87si4jak7k.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=arnd@arndb.de \
--cc=bart.vanassche@sandisk.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).