* [PATCH] raid5-cache: add crc32c Kconfig dependency
@ 2015-11-03 14:12 Arnd Bergmann
2015-11-06 3:19 ` Neil Brown
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2015-11-03 14:12 UTC (permalink / raw)
To: Neil Brown
Cc: Shaohua Li, Bart Van Assche, linux-raid, linux-kernel,
linux-arm-kernel
The recent change of the raid5-cache code to use crc32c instead
of crc32 causes link errors when CONFIG_LIBCRC32C is disabled:
drivers/built-in.o: In function crc32c'
core.c:(.text+0x1c6060): undefined reference to `crc32c'
This adds an explicit 'select' statement like all other users
of this function do.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 5cb2fbd6ea0d ("raid5-cache: use crc32c checksum")
diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
index 3e01e6fb3424..7913fdcfc849 100644
--- a/drivers/md/Kconfig
+++ b/drivers/md/Kconfig
@@ -123,6 +123,7 @@ config MD_RAID456
tristate "RAID-4/RAID-5/RAID-6 mode"
depends on BLK_DEV_MD
select RAID6_PQ
+ select LIBCRC32C
select ASYNC_MEMCPY
select ASYNC_XOR
select ASYNC_PQ
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] raid5-cache: add crc32c Kconfig dependency
2015-11-03 14:12 [PATCH] raid5-cache: add crc32c Kconfig dependency Arnd Bergmann
@ 2015-11-06 3:19 ` Neil Brown
0 siblings, 0 replies; 2+ messages in thread
From: Neil Brown @ 2015-11-06 3:19 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Shaohua Li, Bart Van Assche, linux-raid, linux-kernel,
linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
On Wed, Nov 04 2015, Arnd Bergmann wrote:
> The recent change of the raid5-cache code to use crc32c instead
> of crc32 causes link errors when CONFIG_LIBCRC32C is disabled:
>
> drivers/built-in.o: In function crc32c'
> core.c:(.text+0x1c6060): undefined reference to `crc32c'
>
> This adds an explicit 'select' statement like all other users
> of this function do.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 5cb2fbd6ea0d ("raid5-cache: use crc32c checksum")
>
> diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
> index 3e01e6fb3424..7913fdcfc849 100644
> --- a/drivers/md/Kconfig
> +++ b/drivers/md/Kconfig
> @@ -123,6 +123,7 @@ config MD_RAID456
> tristate "RAID-4/RAID-5/RAID-6 mode"
> depends on BLK_DEV_MD
> select RAID6_PQ
> + select LIBCRC32C
> select ASYNC_MEMCPY
> select ASYNC_XOR
> select ASYNC_PQ
Applied, thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-06 3:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-03 14:12 [PATCH] raid5-cache: add crc32c Kconfig dependency Arnd Bergmann
2015-11-06 3:19 ` Neil Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).