From: NeilBrown <neilb@suse.com>
Cc: linux-raid@vger.kernel.org, Guoqing Jiang <gqjiang@suse.com>
Subject: Re: [PATCH] md: remove unnecesary md_new_event_inintr
Date: Mon, 04 Jan 2016 12:36:25 +1100 [thread overview]
Message-ID: <87twmuxh0m.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <1451270798-25056-1-git-send-email-gqjiang@suse.com>
[-- Attachment #1: Type: text/plain, Size: 1346 bytes --]
On Mon, Dec 28 2015, Guoqing Jiang wrote:
> md_new_event had removed sysfs_notify since 'commit 72a23c211e45
> ("Make sure all changes to md/sync_action are notified.")', so we
> can use md_new_event and delete md_new_event_inintr.
>
> Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
> ---
> drivers/md/md.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index c0c3e6d..43a1404 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -205,15 +205,6 @@ void md_new_event(struct mddev *mddev)
> }
> EXPORT_SYMBOL_GPL(md_new_event);
>
> -/* Alternate version that can be called from interrupts
> - * when calling sysfs_notify isn't needed.
> - */
> -static void md_new_event_inintr(struct mddev *mddev)
> -{
> - atomic_inc(&md_event_count);
> - wake_up(&md_event_waiters);
> -}
> -
> /*
> * Enables to iterate over all existing md arrays
> * all_mddevs_lock protects this list.
> @@ -7209,7 +7200,7 @@ void md_error(struct mddev *mddev, struct md_rdev *rdev)
> md_wakeup_thread(mddev->thread);
> if (mddev->event_work.func)
> queue_work(md_misc_wq, &mddev->event_work);
> - md_new_event_inintr(mddev);
> + md_new_event(mddev);
> }
> EXPORT_SYMBOL(md_error);
>
> --
> 2.6.2
Applied, thanks.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
prev parent reply other threads:[~2016-01-04 1:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-28 2:46 [PATCH] md: remove unnecesary md_new_event_inintr Guoqing Jiang
2016-01-04 1:36 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twmuxh0m.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=gqjiang@suse.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).