From: NeilBrown <neilb@suse.com>
To: Jens Axboe <axboe@kernel.dk>, Jack Wang <jinpu.wang@profitbricks.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
Kent Overstreet <kent.overstreet@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Mike Snitzer <snitzer@redhat.com>,
Mikulas Patocka <mpatocka@redhat.com>,
linux-raid@vger.kernel.org,
device-mapper development <dm-devel@redhat.com>,
linux-block@vger.kernel.org
Subject: Re: [PATCH v2] blk: improve order of bio handling in generic_make_request()
Date: Fri, 10 Mar 2017 16:19:14 +1100 [thread overview]
Message-ID: <87varhg14d.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <58be6551-4aa7-72ee-1616-a1545606d029@kernel.dk>
[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]
On Thu, Mar 09 2017, Jens Axboe wrote:
> On 03/09/2017 09:32 PM, NeilBrown wrote:
>>
>> I started looking further at the improvements we can make once
>> generic_make_request is fixed, and realised that I had missed an
>> important detail in this patch.
>> Several places test current->bio_list, and two actually edit the list.
>> With this change, that cannot see the whole lists, so it could cause a
>> regression.
>>
>> So I've revised the patch to make sure that the entire list of queued
>> bios remains visible, and change the relevant code to look at both
>> the new list and the old list.
>>
>> Following that there are some patches which make the rescuer thread
>> optional, and then starts removing it from some easy-to-fix places.
>
> Neil, note that the v2 patch is already in Linus tree as of earlier
> today. You need to rebase the series, and if we need fixups on
> top of v2, then that should be done separately and with increased
> urgency.
I had checked linux-next, but not the latest from Linus.
I see it now - thanks!
I'll rebase (and ensure nothing gets mangled)
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-03-10 5:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87h93blz6g.fsf@notabene.neil.brown.name>
[not found] ` <71562c2c-97f4-9a0a-32ec-30e0702ca575@profitbricks.com>
[not found] ` <87lgsjj9w8.fsf@notabene.neil.brown.name>
[not found] ` <a674456d-fb93-437e-c50e-195e7a035ba4@kernel.dk>
2017-03-07 20:38 ` [PATCH v2] blk: improve order of bio handling in generic_make_request() NeilBrown
2017-03-10 4:32 ` NeilBrown
2017-03-10 4:33 ` [PATCH 1/5 v3] " NeilBrown
2017-03-10 4:34 ` [PATCH 2/5] blk: remove bio_set arg from blk_queue_split() NeilBrown
2017-03-10 4:35 ` [PATCH 3/5] blk: make the bioset rescue_workqueue optional NeilBrown
2017-03-10 4:36 ` [PATCH 4/5] blk: use non-rescuing bioset for q->bio_split NeilBrown
2017-03-10 4:37 ` [PATCH 5/5] block_dev: make blkdev_dio_pool a non-rescuing bioset NeilBrown
2017-03-10 4:38 ` [PATCH v2] blk: improve order of bio handling in generic_make_request() Jens Axboe
2017-03-10 4:40 ` Jens Axboe
2017-03-10 5:19 ` NeilBrown [this message]
2017-03-10 12:34 ` Lars Ellenberg
2017-03-10 14:38 ` Mike Snitzer
2017-03-10 14:55 ` Mikulas Patocka
2017-03-10 15:07 ` Jack Wang
2017-03-10 15:35 ` Mike Snitzer
2017-03-10 18:51 ` Lars Ellenberg
2017-03-11 0:47 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87varhg14d.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=jinpu.wang@profitbricks.com \
--cc=kent.overstreet@gmail.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=pavel@ucw.cz \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).