From: NeilBrown <nfbrown@novell.com>
To: linux-raid@vger.kernel.org
Cc: shli@fb.com, dan.j.williams@intel.com, hch@infradead.org,
kernel-team@fb.com, Song Liu <songliubraving@fb.com>
Subject: Re: [RFC 5/5] r5cache: naive reclaim approach
Date: Wed, 01 Jun 2016 13:16:37 +1000 [thread overview]
Message-ID: <87wpm9r42y.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <1464326983-3798454-6-git-send-email-songliubraving@fb.com>
[-- Attachment #1: Type: text/plain, Size: 209 bytes --]
On Fri, May 27 2016, Song Liu wrote:
> + sector_t end = -1L;
Please use "MaxSector", not "-1L".
sector_t might be "long long" so -1L might be wrong.
(I haven't looked at much else in this patch)
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-06-01 3:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 5:29 [RFC 0/5] raid5-cache: the write cache part Song Liu
2016-05-27 5:29 ` [RFC 1/5] add bio_split_mddev Song Liu
2016-05-31 9:13 ` Guoqing Jiang
2016-06-01 13:18 ` Song Liu
2016-05-27 5:29 ` [RFC 2/5] move stripe cache define and functions to raid5.h Song Liu
2016-05-27 5:29 ` [RFC 3/5] r5cache: look up stripe cache for chunk_aligned_read Song Liu
2016-06-01 2:52 ` NeilBrown
2016-06-01 13:23 ` Song Liu
2016-05-27 5:29 ` [RFC 4/5] r5cache: write part of r5cache Song Liu
2016-05-31 9:00 ` Guoqing Jiang
2016-06-01 13:13 ` Song Liu
2016-06-01 3:12 ` NeilBrown
2016-06-01 13:36 ` Song Liu
2016-06-01 22:37 ` NeilBrown
2016-05-27 5:29 ` [RFC 5/5] r5cache: naive reclaim approach Song Liu
2016-06-01 3:16 ` NeilBrown [this message]
2016-06-01 13:24 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpm9r42y.fsf@notabene.neil.brown.name \
--to=nfbrown@novell.com \
--cc=dan.j.williams@intel.com \
--cc=hch@infradead.org \
--cc=kernel-team@fb.com \
--cc=linux-raid@vger.kernel.org \
--cc=shli@fb.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).