From: NeilBrown <neilb@suse.com>
To: "jes.sorensen@gmail.com" <jes.sorensen@gmail.com>
Cc: Linux Raid <linux-raid@vger.kernel.org>
Subject: [mdadm PATCH] mdopen: call "modprobe md_mod" if it might be needed.
Date: Mon, 25 Sep 2017 15:52:19 +1000 [thread overview]
Message-ID: <87y3p372b0.fsf@notabene.neil.brown.name> (raw)
[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]
Creating an array by opening a block-device with major number of 9
will transparently load the md module if needed.
Creating an array by opening
/sys/module/md_mod/parameters/new_array
and writing to it won't, it will just fail if md_mod isn't loaded.
So when opening that file fails with ENOENT, run "modprobe md_mod" and
try again.
This fixes a bug whereby if you have "CREATE names=yes" in mdadm.conf,
and the md modules isn't loaded, then creating or assembling an
array will not honor the "names=yes" configuration.
Signed-off-by: NeilBrown <neilb@suse.com>
---
mdopen.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/mdopen.c b/mdopen.c
index 3c0052f2db23..dcdc6f23e6c1 100644
--- a/mdopen.c
+++ b/mdopen.c
@@ -312,6 +312,10 @@ int create_mddev(char *dev, char *name, int autof, int trustworthy,
if (block_udev)
udev_block(devnm);
fd = open("/sys/module/md_mod/parameters/new_array", O_WRONLY);
+ if (fd < 0 && errno == ENOENT) {
+ system("modprobe md_mod");
+ fd = open("/sys/module/md_mod/parameters/new_array", O_WRONLY);
+ }
if (fd >= 0) {
n = write(fd, devnm, strlen(devnm));
close(fd);
--
2.14.0.rc0.dirty
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next reply other threads:[~2017-09-25 5:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 5:52 NeilBrown [this message]
2017-09-25 15:26 ` [mdadm PATCH] mdopen: call "modprobe md_mod" if it might be needed John Stoffel
2017-09-25 23:50 ` NeilBrown
2017-09-26 15:11 ` Jes Sorensen
2017-09-26 19:12 ` Wols Lists
2017-09-26 20:55 ` John Stoffel
2017-09-27 21:30 ` Jes Sorensen
[not found] ` <cba5f77f-d6de-7a6b-35b0-70b7c56eb3f7@suse.com>
2017-10-10 20:16 ` NeilBrown
2017-10-11 7:39 ` Zhilong Liu
2017-10-12 0:06 ` NeilBrown
2017-10-12 3:55 ` Zhilong Liu
2017-10-12 8:48 ` NeilBrown
2017-10-13 9:16 ` Zhilong Liu
2017-10-15 22:41 ` NeilBrown
2017-10-12 9:55 ` Wols Lists
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3p372b0.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=jes.sorensen@gmail.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).