From: "heming.zhao@suse.com" <heming.zhao@suse.com>
To: linux-raid@vger.kernel.org, song@kernel.org,
guoqing.jiang@cloud.ionos.com
Cc: lidong.zhong@suse.com, xni@redhat.com, neilb@suse.de, colyli@suse.de
Subject: Re: [PATCH v2] md/cluster: block reshape requests with resync job initiated from remote node
Date: Wed, 11 Nov 2020 00:06:44 +0800 [thread overview]
Message-ID: <908ab160-ab34-2416-617b-0d7f22063acd@suse.com> (raw)
In-Reply-To: <1605023409-1994-1-git-send-email-heming.zhao@suse.com>
Hello Song & Guoqing,
Thank you for your kindly review.
I feel it's unclear and mess up to put patch 1 & 2 together.
So I split them and first send patch 1 for review.
I am not sure whether I should add "reviewd-by Song & Guoqing" in comments.
Because the code is correct, comments need to revise.
btw,
For patch 2, I need some time to answer Guoqing's question. please wait.
Thanks.
On 11/10/20 11:50 PM, Zhao Heming wrote:
> In cluster env, a node can start resync job when the resync cmd was
> executed on a different node. Reshape requests should be blocked for
> resync job initiated by any node. Current code only checks local resync
> condition to block reshape requests. This results in a chaos result when
> resync was doing on different node.
>
> Fix this by adding the extra check MD_RESYNCING_REMOTE.
>
> ... ...
>
> Signed-off-by: Zhao Heming <heming.zhao@suse.com>
> ---
> v2:
> - for clearly, split patch-v1 into two single patch to review.
> - revise patch subject & comments.
> - add test result in comments.
>
> v1:
> - add cover-letter
> - add more descriptions in commit log
>
> v0:
> - create 2 patches, patch 1/2 is this patch.
>
> ---
> drivers/md/md.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
prev parent reply other threads:[~2020-11-10 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 15:50 [PATCH v2] md/cluster: block reshape requests with resync job initiated from remote node Zhao Heming
2020-11-10 16:06 ` heming.zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=908ab160-ab34-2416-617b-0d7f22063acd@suse.com \
--to=heming.zhao@suse.com \
--cc=colyli@suse.de \
--cc=guoqing.jiang@cloud.ionos.com \
--cc=lidong.zhong@suse.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=song@kernel.org \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox