From: Yu Kuai <yukuai1@huaweicloud.com>
To: Yuan Can <yuancan@huawei.com>,
song@kernel.org, linux-raid@vger.kernel.org,
"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH] md/md-bitmap: Add missing destroy_work_on_stack()
Date: Wed, 6 Nov 2024 09:05:42 +0800 [thread overview]
Message-ID: <90dbe078-986d-46fa-0a46-2f8eaa070e09@huaweicloud.com> (raw)
In-Reply-To: <20241105130105.127336-1-yuancan@huawei.com>
在 2024/11/05 21:01, Yuan Can 写道:
> This commit add missed destroy_work_on_stack() operations for
> unplug_work.work in bitmap_unplug_async().
>
> Fixes: a022325ab970 ("md/md-bitmap: add a new helper to unplug bitmap asynchrously")
> Signed-off-by: Yuan Can <yuancan@huawei.com>
> ---
> drivers/md/md-bitmap.c | 1 +
> 1 file changed, 1 insertion(+)
>
LGTM
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
> diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c
> index 29da10e6f703..c3a42dd66ce5 100644
> --- a/drivers/md/md-bitmap.c
> +++ b/drivers/md/md-bitmap.c
> @@ -1285,6 +1285,7 @@ static void bitmap_unplug_async(struct bitmap *bitmap)
>
> queue_work(md_bitmap_wq, &unplug_work.work);
> wait_for_completion(&done);
> + destroy_work_on_stack(&unplug_work.work);
> }
>
> static void bitmap_unplug(struct mddev *mddev, bool sync)
>
prev parent reply other threads:[~2024-11-06 1:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 13:01 [PATCH] md/md-bitmap: Add missing destroy_work_on_stack() Yuan Can
2024-11-06 1:05 ` Yu Kuai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90dbe078-986d-46fa-0a46-2f8eaa070e09@huaweicloud.com \
--to=yukuai1@huaweicloud.com \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=yuancan@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox