From: Guoqing Jiang <guoqing.jiang@linux.dev>
To: Logan Gunthorpe <logang@deltatee.com>,
Yu Kuai <yukuai1@huaweicloud.com>,
song@kernel.org
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai3@huawei.com, yi.zhang@huawei.com
Subject: Re: [PATCH -next 2/3] md/raid10: convert resync_lock to use seqlock
Date: Fri, 2 Sep 2022 08:49:37 +0800 [thread overview]
Message-ID: <917c01c1-1e2b-66f9-69f1-ed706b7ffc8f@linux.dev> (raw)
In-Reply-To: <04128618-962f-fd4e-64a9-09ecf7f83776@deltatee.com>
On 9/2/22 2:41 AM, Logan Gunthorpe wrote:
> Hi,
>
> On 2022-08-29 07:15, Yu Kuai wrote:
>> From: Yu Kuai <yukuai3@huawei.com>
>>
>> Currently, wait_barrier() will hold 'resync_lock' to read 'conf->barrier',
>> and io can't be dispatched until 'barrier' is dropped.
>>
>> Since holding the 'barrier' is not common, convert 'resync_lock' to use
>> seqlock so that holding lock can be avoided in fast path.
>>
>> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> I've found some lockdep issues starting with this patch in md-next while
> running mdadm tests (specifically 00raid10 when run about 10 times in a
> row).
>
> I've seen a couple different lock dep errors. The first seems to be
> reproducible on this patch, then it possibly changes to the second on
> subsequent patches. Not sure exactly.
That's why I said "try mdadm test suites too to avoid regression." ...
Guoqing
next prev parent reply other threads:[~2022-09-02 0:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 13:14 [PATCH -next 0/3] md/raid10: reduce lock contention for io Yu Kuai
2022-08-29 13:15 ` [PATCH -next 1/3] md/raid10: fix improper BUG_ON() in raise_barrier() Yu Kuai
2022-08-29 19:53 ` John Stoffel
2022-08-30 1:01 ` Yu Kuai
2022-08-30 6:32 ` Paul Menzel
2022-08-29 13:15 ` [PATCH -next 2/3] md/raid10: convert resync_lock to use seqlock Yu Kuai
2022-09-01 18:41 ` Logan Gunthorpe
2022-09-02 0:49 ` Guoqing Jiang [this message]
2022-09-02 0:56 ` Logan Gunthorpe
2022-09-02 1:00 ` Guoqing Jiang
2022-09-02 1:21 ` Yu Kuai
2022-09-02 8:14 ` Yu Kuai
2022-09-02 17:03 ` Logan Gunthorpe
2022-09-03 6:07 ` Yu Kuai
2022-09-02 9:42 ` Guoqing Jiang
2022-09-02 10:02 ` Yu Kuai
2022-09-02 10:16 ` Guoqing Jiang
2022-09-02 10:53 ` Yu Kuai
2022-08-29 13:15 ` [PATCH -next 3/3] md/raid10: prevent unnecessary calls to wake_up() in fast path Yu Kuai
2022-08-29 13:40 ` [PATCH -next 0/3] md/raid10: reduce lock contention for io Guoqing Jiang
2022-08-31 11:55 ` Yu Kuai
2022-08-29 13:58 ` Paul Menzel
2022-08-30 1:09 ` Yu Kuai
2022-08-31 11:59 ` Paul Menzel
2022-08-31 12:07 ` Yu Kuai
2022-08-31 18:00 ` Song Liu
2022-09-03 6:08 ` Yu Kuai
2022-09-09 14:45 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=917c01c1-1e2b-66f9-69f1-ed706b7ffc8f@linux.dev \
--to=guoqing.jiang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=song@kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox