* [PATCH] md/raid10: properly indicate failure when ending a failed write request
@ 2021-06-24 18:27 wsy
2021-06-25 1:58 ` Guoqing Jiang
0 siblings, 1 reply; 5+ messages in thread
From: wsy @ 2021-06-24 18:27 UTC (permalink / raw)
To: Song Liu; +Cc: linux-raid, Paul Clements, Yufen Yu
Similar to commit 2417b9869b81882ab90fd5ed1081a1cb2d4db1dd, this patch
fixes the same bug in raid10.
Fixes: 7cee6d4e6035 ("md/raid10: end bio when the device faulty")
Signed-off-by: Wei Shuyu <wsy@dogben.com>
---
Maybe there are other bugs fixed in one but left open in the other?
drivers/md/raid10.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index 13f5e6b2a73d..f9c3b2323d7c 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -475,6 +475,8 @@ static void raid10_end_write_request(struct bio *bio)
if (!test_bit(Faulty, &rdev->flags))
set_bit(R10BIO_WriteError, &r10_bio->state);
else {
+ /* Fail the request */
+ set_bit(R10BIO_Degraded, &r10_bio->state);
r10_bio->devs[slot].bio = NULL;
to_put = bio;
dec_rdev = 1;
--
2.32.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] md/raid10: properly indicate failure when ending a failed write request
2021-06-24 18:27 [PATCH] md/raid10: properly indicate failure when ending a failed write request wsy
@ 2021-06-25 1:58 ` Guoqing Jiang
2021-06-25 3:03 ` Wei Shuyu
0 siblings, 1 reply; 5+ messages in thread
From: Guoqing Jiang @ 2021-06-25 1:58 UTC (permalink / raw)
To: wsy, Song Liu; +Cc: linux-raid, Paul Clements, Yufen Yu
On 6/25/21 2:27 AM, wsy@dogben.com wrote:
> Similar to commit 2417b9869b81882ab90fd5ed1081a1cb2d4db1dd, this patch
> fixes the same bug in raid10.
>
> Fixes: 7cee6d4e6035 ("md/raid10: end bio when the device faulty")
> Signed-off-by: Wei Shuyu <wsy@dogben.com>
> ---
>
> Maybe there are other bugs fixed in one but left open in the other?
>
> drivers/md/raid10.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index 13f5e6b2a73d..f9c3b2323d7c 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -475,6 +475,8 @@ static void raid10_end_write_request(struct bio *bio)
> if (!test_bit(Faulty, &rdev->flags))
> set_bit(R10BIO_WriteError, &r10_bio->state);
> else {
> + /* Fail the request */
> + set_bit(R10BIO_Degraded, &r10_bio->state);
> r10_bio->devs[slot].bio = NULL;
> to_put = bio;
> dec_rdev = 1;
While at it, could you also delete the incorrect comment? I don't know
how the above part is relevant
with failfast after the refactor.
/*
* When the device is faulty, it is not
necessary to
* handle write error.
- * For failfast, this is the only remaining device,
- * We need to retry the write without FailFast.
*/
Thanks,
Guoqing
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] md/raid10: properly indicate failure when ending a failed write request
2021-06-25 1:58 ` Guoqing Jiang
@ 2021-06-25 3:03 ` Wei Shuyu
2021-06-25 3:14 ` Guoqing Jiang
2021-06-25 14:20 ` Song Liu
0 siblings, 2 replies; 5+ messages in thread
From: Wei Shuyu @ 2021-06-25 3:03 UTC (permalink / raw)
To: Guoqing Jiang; +Cc: Song Liu, linux-raid, Paul Clements, Yufen Yu
On 2021-06-25 09:58, Guoqing Jiang wrote:
> On 6/25/21 2:27 AM, wsy@dogben.com wrote:
>> Similar to commit 2417b9869b81882ab90fd5ed1081a1cb2d4db1dd, this patch
>> fixes the same bug in raid10.
>>
>> Fixes: 7cee6d4e6035 ("md/raid10: end bio when the device faulty")
>> Signed-off-by: Wei Shuyu <wsy@dogben.com>
>> ---
>>
>> Maybe there are other bugs fixed in one but left open in the other?
>>
>> drivers/md/raid10.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
>> index 13f5e6b2a73d..f9c3b2323d7c 100644
>> --- a/drivers/md/raid10.c
>> +++ b/drivers/md/raid10.c
>> @@ -475,6 +475,8 @@ static void raid10_end_write_request(struct bio
>> *bio)
>> if (!test_bit(Faulty, &rdev->flags))
>> set_bit(R10BIO_WriteError, &r10_bio->state);
>> else {
>> + /* Fail the request */
>> + set_bit(R10BIO_Degraded, &r10_bio->state);
>> r10_bio->devs[slot].bio = NULL;
>> to_put = bio;
>> dec_rdev = 1;
>
> While at it, could you also delete the incorrect comment? I don't know
> how the above part is relevant
> with failfast after the refactor.
>
> /*
> * When the device is faulty, it is not
> necessary to
> * handle write error.
> - * For failfast, this is the only remaining
> device,
> - * We need to retry the write without FailFast.
> */
>
> Thanks,
> Guoqing
Shall I make another patch that fix the comments in both files or just
piggyback in V2?
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] md/raid10: properly indicate failure when ending a failed write request
2021-06-25 3:03 ` Wei Shuyu
@ 2021-06-25 3:14 ` Guoqing Jiang
2021-06-25 14:20 ` Song Liu
1 sibling, 0 replies; 5+ messages in thread
From: Guoqing Jiang @ 2021-06-25 3:14 UTC (permalink / raw)
To: Wei Shuyu, Guoqing Jiang; +Cc: Song Liu, linux-raid, Paul Clements, Yufen Yu
On 6/25/21 11:03 AM, Wei Shuyu wrote:
> On 2021-06-25 09:58, Guoqing Jiang wrote:
>> On 6/25/21 2:27 AM, wsy@dogben.com wrote:
>>> Similar to commit 2417b9869b81882ab90fd5ed1081a1cb2d4db1dd, this patch
>>> fixes the same bug in raid10.
>>>
>>> Fixes: 7cee6d4e6035 ("md/raid10: end bio when the device faulty")
>>> Signed-off-by: Wei Shuyu <wsy@dogben.com>
>>> ---
>>>
>>> Maybe there are other bugs fixed in one but left open in the other?
>>>
>>> drivers/md/raid10.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
>>> index 13f5e6b2a73d..f9c3b2323d7c 100644
>>> --- a/drivers/md/raid10.c
>>> +++ b/drivers/md/raid10.c
>>> @@ -475,6 +475,8 @@ static void raid10_end_write_request(struct bio
>>> *bio)
>>> if (!test_bit(Faulty, &rdev->flags))
>>> set_bit(R10BIO_WriteError, &r10_bio->state);
>>> else {
>>> + /* Fail the request */
>>> + set_bit(R10BIO_Degraded, &r10_bio->state);
>>> r10_bio->devs[slot].bio = NULL;
>>> to_put = bio;
>>> dec_rdev = 1;
>>
>> While at it, could you also delete the incorrect comment? I don't know
>> how the above part is relevant
>> with failfast after the refactor.
>>
>> /*
>> * When the device is faulty, it is not
>> necessary to
>> * handle write error.
>> - * For failfast, this is the only remaining
>> device,
>> - * We need to retry the write without FailFast.
>> */
>>
>> Thanks,
>> Guoqing
>
> Shall I make another patch that fix the comments in both files or just
> piggyback in V2?
It is up to you, I don't have strong opinion for it.
Thanks,
Guoqing
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] md/raid10: properly indicate failure when ending a failed write request
2021-06-25 3:03 ` Wei Shuyu
2021-06-25 3:14 ` Guoqing Jiang
@ 2021-06-25 14:20 ` Song Liu
1 sibling, 0 replies; 5+ messages in thread
From: Song Liu @ 2021-06-25 14:20 UTC (permalink / raw)
To: Wei Shuyu; +Cc: Guoqing Jiang, linux-raid, Paul Clements, Yufen Yu
On Thu, Jun 24, 2021 at 8:04 PM Wei Shuyu <wsy@dogben.com> wrote:
>
[...]
> > Thanks,
> > Guoqing
>
> Shall I make another patch that fix the comments in both files or just
> piggyback in V2?
Let's piggyback in V2.
Thanks,
Song
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-25 14:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-24 18:27 [PATCH] md/raid10: properly indicate failure when ending a failed write request wsy
2021-06-25 1:58 ` Guoqing Jiang
2021-06-25 3:03 ` Wei Shuyu
2021-06-25 3:14 ` Guoqing Jiang
2021-06-25 14:20 ` Song Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox