Re: [PATCH V3 2/6] md: ignore discard return value

[Chaitanya Kulkarni <chaitanyak@nvidia.com>]

Hi Song Liu and Yu Kuai,

On 11/24/25 15:48, Chaitanya Kulkarni wrote:
> __blkdev_issue_discard() always returns 0, making all error checking at
> call sites dead code.
>
> Simplify md to only check !discard_bio by ignoring the
> __blkdev_issue_discard() value.
>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Chaitanya Kulkarni <ckulkarnilinux@gmail.com>
> ---
>   drivers/md/md.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 7b5c5967568f..aeb62df39828 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -9132,8 +9132,8 @@ void md_submit_discard_bio(struct mddev *mddev, struct md_rdev *rdev,
>   {
>   	struct bio *discard_bio = NULL;
>   
> -	if (__blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO,
> -			&discard_bio) || !discard_bio)
> +	__blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO, &discard_bio);
> +	if (!discard_bio)
>   		return;
>   
>   	bio_chain(discard_bio, bio);


Gentle ping on this.

-ck