* [PATCH] block: missing break in process_queued_bios()
@ 2017-06-14 9:04 Dan Carpenter
2017-06-14 9:07 ` Christoph Hellwig
2017-06-14 13:18 ` Mike Snitzer
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-06-14 9:04 UTC (permalink / raw)
To: Alasdair Kergon, Christoph Hellwig
Cc: linux-raid, kernel-janitors, dm-devel, Shaohua Li, Mike Snitzer
This used to be a fall through case, but we shifted code around and I
think we want a break here now.
Fixes: 4e4cbee93d56 ("block: switch bios to blk_status_t")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index a7d2e0840cc5..0e8ab5bb3575 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -625,6 +625,7 @@ static void process_queued_bios(struct work_struct *work)
case DM_MAPIO_KILL:
bio->bi_status = BLK_STS_IOERR;
bio_endio(bio);
+ break;
case DM_MAPIO_REQUEUE:
bio->bi_status = BLK_STS_DM_REQUEUE;
bio_endio(bio);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] block: missing break in process_queued_bios()
2017-06-14 9:04 [PATCH] block: missing break in process_queued_bios() Dan Carpenter
@ 2017-06-14 9:07 ` Christoph Hellwig
2017-06-14 13:18 ` Mike Snitzer
1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2017-06-14 9:07 UTC (permalink / raw)
To: Dan Carpenter
Cc: Mike Snitzer, kernel-janitors, linux-raid, dm-devel, Shaohua Li,
Christoph Hellwig, Alasdair Kergon
On Wed, Jun 14, 2017 at 12:04:37PM +0300, Dan Carpenter wrote:
> This used to be a fall through case, but we shifted code around and I
> think we want a break here now.
>
> Fixes: 4e4cbee93d56 ("block: switch bios to blk_status_t")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks Dan, this looks coreect:
Acked-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: block: missing break in process_queued_bios()
2017-06-14 9:04 [PATCH] block: missing break in process_queued_bios() Dan Carpenter
2017-06-14 9:07 ` Christoph Hellwig
@ 2017-06-14 13:18 ` Mike Snitzer
2017-06-14 14:23 ` Jens Axboe
1 sibling, 1 reply; 4+ messages in thread
From: Mike Snitzer @ 2017-06-14 13:18 UTC (permalink / raw)
To: Dan Carpenter, axboe
Cc: Alasdair Kergon, Christoph Hellwig, dm-devel, Shaohua Li,
linux-raid, kernel-janitors
On Wed, Jun 14 2017 at 5:04am -0400,
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This used to be a fall through case, but we shifted code around and I
> think we want a break here now.
>
> Fixes: 4e4cbee93d56 ("block: switch bios to blk_status_t")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
> index a7d2e0840cc5..0e8ab5bb3575 100644
> --- a/drivers/md/dm-mpath.c
> +++ b/drivers/md/dm-mpath.c
> @@ -625,6 +625,7 @@ static void process_queued_bios(struct work_struct *work)
> case DM_MAPIO_KILL:
> bio->bi_status = BLK_STS_IOERR;
> bio_endio(bio);
> + break;
> case DM_MAPIO_REQUEUE:
> bio->bi_status = BLK_STS_DM_REQUEUE;
> bio_endio(bio);
Annoyed with myself for missing this during my review...
The subject should be:
"dm mpath: add missing break in process_queued_bios()"
Also, this should go through Jens and I'll rebase my linux-dm branches
accordingly. Jens, please pick this up.
Acked-by: Mike Snitzer <snitzer@redhat.com>
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: block: missing break in process_queued_bios()
2017-06-14 13:18 ` Mike Snitzer
@ 2017-06-14 14:23 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2017-06-14 14:23 UTC (permalink / raw)
To: Mike Snitzer, Dan Carpenter
Cc: Alasdair Kergon, Christoph Hellwig, dm-devel, Shaohua Li,
linux-raid, kernel-janitors
On 06/14/2017 07:18 AM, Mike Snitzer wrote:
> On Wed, Jun 14 2017 at 5:04am -0400,
> Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
>> This used to be a fall through case, but we shifted code around and I
>> think we want a break here now.
>>
>> Fixes: 4e4cbee93d56 ("block: switch bios to blk_status_t")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
>> index a7d2e0840cc5..0e8ab5bb3575 100644
>> --- a/drivers/md/dm-mpath.c
>> +++ b/drivers/md/dm-mpath.c
>> @@ -625,6 +625,7 @@ static void process_queued_bios(struct work_struct *work)
>> case DM_MAPIO_KILL:
>> bio->bi_status = BLK_STS_IOERR;
>> bio_endio(bio);
>> + break;
>> case DM_MAPIO_REQUEUE:
>> bio->bi_status = BLK_STS_DM_REQUEUE;
>> bio_endio(bio);
>
> Annoyed with myself for missing this during my review...
>
> The subject should be:
> "dm mpath: add missing break in process_queued_bios()"
>
> Also, this should go through Jens and I'll rebase my linux-dm branches
> accordingly. Jens, please pick this up.
>
> Acked-by: Mike Snitzer <snitzer@redhat.com>
Thanks, I've added it to the 4.13 branch.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-14 14:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-14 9:04 [PATCH] block: missing break in process_queued_bios() Dan Carpenter
2017-06-14 9:07 ` Christoph Hellwig
2017-06-14 13:18 ` Mike Snitzer
2017-06-14 14:23 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).