From: Jens Axboe <axboe@kernel.dk>
To: Song Liu <songliubraving@fb.com>,
linux-raid@vger.kernel.org, linux-block@vger.kernel.org
Cc: kernel-team@fb.com, neilb@suse.com, xni@redhat.com,
ncroxon@redhat.com, stable@vger.kernel.org,
David Jeffy <djeffery@redhat.com>
Subject: Re: [PATCH 1/3] Don't jump to compute_result state from check_result state
Date: Fri, 29 Mar 2019 11:51:11 -0600 [thread overview]
Message-ID: <97dc86ee-b9d6-152e-ba5a-b485ac6a3fde@kernel.dk> (raw)
In-Reply-To: <20190329174617.3670341-2-songliubraving@fb.com>
On 3/29/19 11:46 AM, Song Liu wrote:
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index c033bfcb209e..4204a972ecf2 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -4223,26 +4223,15 @@ static void handle_parity_checks6(struct r5conf *conf, struct stripe_head *sh,
> case check_state_check_result:
> sh->check_state = check_state_idle;
>
> + if (s->failed > 1)
> + break;
Not sure what happened here, but there's a lot of whitespace after that
if statement, and the break is using 4 spaces instead of a tab. I fixed
both of these up, but please review the style of patches going forward.
--
Jens Axboe
next prev parent reply other threads:[~2019-03-29 17:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190329174617.3670341-1-songliubraving@fb.com>
2019-03-29 17:46 ` [PATCH 1/3] Don't jump to compute_result state from check_result state Song Liu
2019-03-29 17:51 ` Jens Axboe [this message]
2019-03-29 18:11 ` Song Liu
2019-03-29 17:46 ` [PATCH 2/3] Revert "MD: fix lock contention for flush bios" Song Liu
2019-03-29 17:46 ` [PATCH 3/3] md: batch flush requests Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97dc86ee-b9d6-152e-ba5a-b485ac6a3fde@kernel.dk \
--to=axboe@kernel.dk \
--cc=djeffery@redhat.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=ncroxon@redhat.com \
--cc=neilb@suse.com \
--cc=songliubraving@fb.com \
--cc=stable@vger.kernel.org \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox