public inbox for linux-raid@vger.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <jes@trained-monkey.org>
To: Sudhakar Panneerselvam <sudhakar.panneerselvam@oracle.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 4/5] tests: fix swap_super path
Date: Mon, 2 Aug 2021 11:48:39 -0400	[thread overview]
Message-ID: <9cf86355-23fc-5e19-f9dd-8325a89f0c43@trained-monkey.org> (raw)
In-Reply-To: <20210722182903.GA25359@oracle.com>

On 7/22/21 2:29 PM, Sudhakar Panneerselvam wrote:
> This fixes '04r5swap' test.
> 
> Signed-off-by: Sudhakar Panneerselvam <sudhakar.panneerselvam@oracle.com>
> ---
>  tests/04r5swap | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/04r5swap b/tests/04r5swap
> index 5373a60725fb..8c6a97ba7339 100644
> --- a/tests/04r5swap
> +++ b/tests/04r5swap
> @@ -7,7 +7,7 @@ mdadm -S $md0
>  
>  mdadm -E --metadata=0 $dev1  > $targetdir/d1
>  for d in $dev0 $dev1 $dev2 $dev3
> -do $dir/swap_super $d
> +do $PWD/swap_super $d
>  done
>  mdadm -E --metadata=0.swap  $dev1  > $targetdir/d1s
>  diff -u $targetdir/d1 $targetdir/d1s
> 

There are a ton of test cases referencing $dir. I'd say either set $dir
correctly or fix all of them.

Thanks,
Jes


      reply	other threads:[~2021-08-02 15:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22 18:29 [PATCH 4/5] tests: fix swap_super path Sudhakar Panneerselvam
2021-08-02 15:48 ` Jes Sorensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9cf86355-23fc-5e19-f9dd-8325a89f0c43@trained-monkey.org \
    --to=jes@trained-monkey.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=sudhakar.panneerselvam@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox