public inbox for linux-raid@vger.kernel.org
 help / color / mirror / Atom feed
From: Coly Li <colyli@suse.de>
To: mtkaczyk <mariusz.tkaczyk@linux.intel.com>
Cc: linux-raid@vger.kernel.org, Benjamin Brunner <bbrunner@suse.com>,
	Neil Brown <neilb@suse.de>, Jes Sorensen <jsorensen@fb.com>
Subject: Re: [PATCH] mdadm/systemd: change KillMode from none to mixed in service files
Date: Thu, 2 Dec 2021 00:23:09 +0800	[thread overview]
Message-ID: <9ee380c8-e43b-8f58-c7d5-5bddb6f2e688@suse.de> (raw)
In-Reply-To: <20211201170843.00005f69@linux.intel.com>

On 12/2/21 12:08 AM, mtkaczyk wrote:
> Hi Coly,
>
>> This patch changes KillMode in above listed service files from "none"
>> to "mixed", to follow systemd recommendation and avoid potential
>> unnecessary issue.
> What about mdmonitor.service? Should we add it there too? Now it is not
> defined.

It was overlooked when I did grep KillMode. Yes, I agree 
mdmonitor.service should have a KillMode key word as well.

Let me post a v2 version.

>> Cc: Jes Sorensen <jsorensen@fb.com>
> Not sure if it a problem but Jes uses: jes@trained-monkey.org for
> communication with linux-raid.

Copied. Thanks for the hint.

Coly Li

  reply	other threads:[~2021-12-01 16:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-01  6:22 [PATCH] mdadm/systemd: change KillMode from none to mixed in service files Coly Li
2021-12-01 16:08 ` mtkaczyk
2021-12-01 16:23   ` Coly Li [this message]
2021-12-01 16:28     ` Benjamin Brunner
2021-12-01 16:43       ` Coly Li
2021-12-01 21:51         ` NeilBrown
2021-12-05 13:42           ` Coly Li
2021-12-07 12:34             ` Benjamin Brunner
2021-12-08 16:25               ` Franck Bui
2021-12-08 21:27                 ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ee380c8-e43b-8f58-c7d5-5bddb6f2e688@suse.de \
    --to=colyli@suse.de \
    --cc=bbrunner@suse.com \
    --cc=jsorensen@fb.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=mariusz.tkaczyk@linux.intel.com \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox