From: Dan Williams <dan.j.williams@intel.com>
To: Adam Kwolek <adam.kwolek@intel.com>
Cc: neilb@suse.de, linux-raid@vger.kernel.org, ed.ciechanowski@intel.com
Subject: Re: [PATCH 03/10] FIX: Add error code for raid_disks set
Date: Thu, 2 Dec 2010 10:56:32 -0800 [thread overview]
Message-ID: <AANLkTi=mf9C9r+QM74EhMPtW35gsa2c5_QGtuxyBxn0V@mail.gmail.com> (raw)
In-Reply-To: <20101202081904.4639.61446.stgit@gklab-170-024.igk.intel.com>
On Thu, Dec 2, 2010 at 12:19 AM, Adam Kwolek <adam.kwolek@intel.com> wrote:
> If error occurs mdadm exits with no information.
>
Unless I am missing another patch all return paths currently have an
error message?
...
if (!ent) {
fprintf(stderr, Name ": unable to read /proc/mdstat\n");
return -1;
}
...
if (rv) {
fprintf(stderr, Name
": failed to initiate container reshape%s%s\n",
err ? ": " : "", err ? strerror(err) : "");
return rv;
}
return changed;
...and 'changed' is never negative.
--
Dan
next prev parent reply other threads:[~2010-12-02 18:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 8:18 [PATCH 00/10] Pre-migration patch series Adam Kwolek
2010-12-02 8:18 ` [PATCH 01/10] FIX: Cannot exit monitor after takeover Adam Kwolek
2010-12-02 8:18 ` [PATCH 02/10] FIX: Problem with removing array " Adam Kwolek
2010-12-03 3:46 ` Neil Brown
2010-12-02 8:19 ` [PATCH 03/10] FIX: Add error code for raid_disks set Adam Kwolek
2010-12-02 18:56 ` Dan Williams [this message]
2010-12-02 8:19 ` [PATCH 04/10] Add support to skip slot configuration Adam Kwolek
2010-12-02 8:19 ` [PATCH 05/10] Add spares to raid0 array using takeover Adam Kwolek
2010-12-03 3:52 ` Neil Brown
2010-12-02 8:19 ` [PATCH 06/10] FIX: open backup file for reshape as function Adam Kwolek
2010-12-03 4:01 ` Neil Brown
2010-12-02 8:19 ` [PATCH 07/10] FIX: Do not use layout for raid4 and raid0 while geo map computing Adam Kwolek
2010-12-02 8:19 ` [PATCH 08/10] FIX: sync_completed_fd handler has to be closed Adam Kwolek
2010-12-02 8:19 ` [PATCH 09/10] FIX: Honor !reshape state on wait_reshape() entry Adam Kwolek
2010-12-03 4:11 ` Neil Brown
2010-12-02 8:19 ` [PATCH 10/10] FIX: wait_backup() sometimes hungs Adam Kwolek
2010-12-03 4:16 ` Neil Brown
2010-12-03 7:45 ` Kwolek, Adam
2010-12-03 10:35 ` Neil Brown
2010-12-03 4:19 ` [PATCH 00/10] Pre-migration patch series Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=mf9C9r+QM74EhMPtW35gsa2c5_QGtuxyBxn0V@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=adam.kwolek@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).