linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Clements <paul.clements@us.sios.com>
To: NeilBrown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org
Subject: Re: [BUG 2.6.32] md/raid1: barrier disabling does not work correctly in all cases
Date: Thu, 20 Jan 2011 15:44:21 -0500	[thread overview]
Message-ID: <AANLkTimN2FOp5X353AfJqnMTL-1nhQH=4uNFt5GNAa7d@mail.gmail.com> (raw)
In-Reply-To: <20110121072515.07dc2b74@notabene.brown>

On Thu, Jan 20, 2011 at 3:25 PM, NeilBrown <neilb@suse.de> wrote:

> Normally the first thing that md/raid1 writes to a member device is the
> metadata.  This is written with a barrier write if possible.  If that fails
> then barriers_work is cleared, so all barrier writes from the filesystem
> (empty or otherwise) will be rejected.

Yes, I noticed that, and assume that's why more people haven't seen
this problem...

> As you are getting an error here I assume that you are using non-persistent
> metadata - correct?

Yep, that's right...

> Nonetheless, I think the correct fix is to add a special case for retrying a
> zero-length.

> Something like this maybe?

Thanks Neil. I will try this patch.

--
Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2011-01-20 20:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AANLkTimp7eGLu5UEr-wH9MVSGrQWA3PKMakW74_48gk7@mail.gmail.com>
2011-01-20 16:52 ` [BUG 2.6.32] md/raid1: barrier disabling does not work correctly in all cases Paul Clements
2011-01-20 20:25   ` NeilBrown
2011-01-20 20:44     ` Paul Clements [this message]
2011-01-26 13:55     ` Paul Clements
2011-02-01 20:45       ` Paul Clements
2011-02-02  0:32         ` NeilBrown
2011-02-02  1:04           ` Paul Clements
2011-02-24 21:04             ` Paul Clements

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTimN2FOp5X353AfJqnMTL-1nhQH=4uNFt5GNAa7d@mail.gmail.com' \
    --to=paul.clements@us.sios.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).