From: Linus Torvalds <torvalds@linux-foundation.org>
To: NeilBrown <neilb@suse.de>
Cc: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Patterson <andrew.patterson@hp.com>,
Jens Axboe <axboe@kernel.dk>, Jeff Moyer <jmoyer@redhat.com>
Subject: Re: [PULL REQUEST] md and related patches for 2.6.38
Date: Wed, 23 Feb 2011 22:01:49 -0800 [thread overview]
Message-ID: <AANLkTinm95OYw2Sj0DuABTiG6eWzePcfAZyxOE0c4GsT@mail.gmail.com> (raw)
In-Reply-To: <20110224165328.46c1169b@notabene.brown>
On Wed, Feb 23, 2011 at 9:53 PM, NeilBrown <neilb@suse.de> wrote:
>
> The most noteworthy is :
> Fix over-zealous flush_disk when changing device size.
>
> which I include below in full.
Gah.
Why did you do that butt-ugly "__invalidate_device2()"?
There are something like three users of that existing
__invalidate_device() function, it would have made for a smaller and
cleaner patch to just fix them all, rather than change the calling
convention, create that ugly "2" function, and add the wrapper
function.
It's _doubly_ crazy, because that's exactly what you did to
"invalidate_inodes()", so it has this crazy mix of "change one
function" and "try to maintain another function unchanged".
Why?
Linus
next parent reply other threads:[~2011-02-24 6:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110224165328.46c1169b@notabene.brown>
2011-02-24 6:01 ` Linus Torvalds [this message]
2011-02-24 6:31 ` [PULL REQUEST] md and related patches for 2.6.38 NeilBrown
2011-02-24 20:21 ` Linus Torvalds
2011-02-25 8:30 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinm95OYw2Sj0DuABTiG6eWzePcfAZyxOE0c4GsT@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=andrew.patterson@hp.com \
--cc=axboe@kernel.dk \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).